search

LootrMinecraft / Lootr

friendly loot
MIT License
49 stars 39 forks source link

[BUG] Create Drill Destroy easy Lootr chests. #514

Closed kitovoi111 closed 2 hours ago

kitovoi111 commented 2 hours ago

image

noobanidus commented 2 hours ago

I'm pretty sure that this issue has been opened several times, potentially by you. As far as I'm aware there's a tag that makes blocks immune to the drill, and you need to add Lootr containers to it.

Again, there is nothing I can do about it on my end.

kitovoi111 commented 2 hours ago

none image

kitovoi111 commented 2 hours ago

You fixed it somehow before, the chests didn't break. After the update they break again

noobanidus commented 2 hours ago

Which update?

kitovoi111 commented 2 hours ago

Which update?

sec

noobanidus commented 2 hours ago

EDIT: Is that a Lootr container or is it a Quark container?

kitovoi111 commented 2 hours ago

EDIT: Is that a Lootr container or is it a Quark container?

I checked on Lootr and Quark containers - all break

noobanidus commented 2 hours ago

Okay, which versions of Minecraft, Lootr, Create, etc, are you currently using? What did you update? What were the previous versions? What other changes have you made?

kitovoi111 commented 1 hour ago

i use Forge 1.19.2

mods: create-1.19.2-0.5.1.i.jar lootr-forge-1.19-0.4.28.74.jar

my config lootr: lootr-common.txt

kitovoi111 commented 1 hour ago

image In version Lootr-67 Lootr no destroying!!!!

kitovoi111 commented 1 hour ago

https://modrinth.com/mod/lootr/version/0.4.25.67 my love version

kitovoi111 commented 1 hour ago

I'm telling you, you broke something in the update! :D

noobanidus commented 1 hour ago

Did you only update Lootr, or did you also update Create?

EDIT: I've looked through the entirety of changes since the 0.4.25.67 release through to HEAD of the 1.19 Forge branch and there are no changes that would cause this.

The only major change that might have any impact was the move from a Mixin of BlockState to implementing getDestroyProgress in the block instead. They are functionally identical, so it's not that.

kitovoi111 commented 1 hour ago

Did you only update Lootr, or did you also update Create?

EDIT: I've looked through the entirety of changes since the 0.4.25.67 release through to HEAD of the 1.19 Forge branch and there are no changes that would cause this.

The only major change that might have any impact was the move from a Mixin of BlockState to implementing getDestroyProgress in the block instead. They are functionally identical, so it's not that.

I've launched it now create-1.19.2-0.5.1.i.jar and lootr-67 version and lootr no destroying

kitovoi111 commented 1 hour ago

But when I launch the new version of lootr - all chests are broken by the drill from Create

noobanidus commented 1 hour ago

Is that -67 from Modrinth, or is it one I compiled specifically for you?

kitovoi111 commented 1 hour ago

Is that -67 from Modrinth, or is it one I compiled specifically for you?

Modrinth.

kitovoi111 commented 43 minutes ago

You can fix please this?

noobanidus commented 43 minutes ago

I'm looking into it but it's proving difficult to debug.

noobanidus commented 14 minutes ago

The only major change that might have any impact was the move from a Mixin of BlockState to implementing getDestroyProgress in the block instead. They are functionally identical, so it's not that.

Turns out my assumption was incorrect, they are not functionally identical although on the surface they appeared to be. I've made a new release for 1.19.