Lootyhoof / compactmoon

Customizable compact theme for Pale Moon
Mozilla Public License 2.0
5 stars 1 forks source link

RFE: CompactMoon Options should have more color (especially dark) schemes #1

Closed TPS closed 6 years ago

TPS commented 7 years ago

@Lootyhoof Especially your dark themes, but others, too:

There really do need to be dark themes customizable like the standard CompactMoon.

Lootyhoof commented 7 years ago

Sorry for the late reply, but what would you be looking for with respect to options for other themes?

The main feature of Compact Moon Options (changing how big/small things are) is not going to work well with other themes and I do not want to introduce it.

TPS commented 7 years ago

Then maybe the other way around, i.e, make Compact Moon have options to look like other themes? E.g., I especially appreciate (& use) your Dark* themes, but I miss the screen estate that Compact Moon freed up.

Lootyhoof commented 7 years ago

This is possible, to an extent, and I may look into it.

TPS commented 7 years ago

@Lootyhoof Just bumping: I really miss CompactMoon's screen real-estate, but DarkPitch is virtually visually perfect for me otherwise. I was hoping you'd a chance to think about this.

For a quick-&-dirty workaround, are their assets laid out similarly? Would, e.g., copying images from DP into CM make this somewhat functional?

Lootyhoof commented 7 years ago

For a quick-&-dirty workaround, are their assets laid out similarly?

No. It's not that simple, unfortunately.

I will be addressing this, it just takes time given I've other themes to address first.

TPS commented 7 years ago

Thanks, I really appreciate it.

TPS commented 6 years ago

@Lootyhoof Are some of the recent flurry of commits preliminary work on this? (Somethings I see look like such.… 🤞)

Lootyhoof commented 6 years ago

Yes, the work has been ongoing since https://github.com/Lootyhoof/compactmoon/commit/b00504f3e2bb6012884416e9ac30e4ffb85914d8 (I got a little sidetracked during then for other bugs in other themes). It's a rather large update, but includes a lot of new features and fixes in addition to dark mode (which has not yet been added, but is certainly possible now).

TPS commented 6 years ago

Fantastic! Do lemme know if you want testing/feedback/whatever: I'm happy to help, though not really a coder.

Lootyhoof commented 6 years ago

v2.0.0b1 is out now, check the releases page. I'd appreciate if you could check it out and let me know of any issues. Check the changelog for details on other changes. Of note, you'll find the relevant options within the Compact Moon Options window.

This dark theme should also work reasonably well with personas, assuming you use another extension such as ThemeTool.

Thanks!

TPS commented 6 years ago

Installing now.... I guess no hope to make them restartless? I'll post back after I restart & play w/ them some. Thanks!

Lootyhoof commented 6 years ago

It's not possible to make themes restartless due to needing to takeover overlays in use, and have no plans to make the extension restartless, sorry.

TPS commented 6 years ago

So far, fantastic, other than 1 color detail that's probably a conflict w/ another addon. I'll post if I can't resolve that way.

TPS commented 6 years ago

IMHO, time to release. (That was a conflict with an officially unsupported addon; disabling it fixed it). This is pretty much everything I wanted! :raised_hands:

Lootyhoof commented 6 years ago

Out of curiosity, which addon was it?

I'll do some more cleanup and testing and probably release in a couple days.

TPS commented 6 years ago

LocationBar³