Lootyhoof / darkmoon

Dark theme for Pale Moon
Mozilla Public License 2.0
19 stars 6 forks source link

Revamped "aboutDialog" box issues... #3

Closed Vangelis66 closed 5 years ago

Vangelis66 commented 5 years ago

First, huge thanks for creating and maintaining my preferred dark theme for the Pale Moon browser ๐Ÿฅ‡

My specifics: OS: Windows 7 SP1 32-bit (Windows Aero enabled) Browser: Pale Moon 28 (on UXP platform) Update channel: Unstable appVersion: 28.5.0a1 buildID: 20190328093130 Complete Theme used: Dark Moon 2.3.1 (latest)

Issue details: After the recent Pale Moon "aboutDialog" box redesign (kindly look at https://github.com/MoonchildProductions/UXP/issues/963 https://github.com/MoonchildProductions/UXP/pull/985 and (individual commits) https://github.com/MoonchildProductions/UXP/commit/a61164a https://github.com/MoonchildProductions/UXP/commit/7f61379 https://github.com/MoonchildProductions/UXP/commit/f0c57ac https://github.com/MoonchildProductions/UXP/commit/97be0f6 https://github.com/MoonchildProductions/UXP/commit/a7bca40 https://github.com/MoonchildProductions/UXP/commit/403605e https://github.com/MoonchildProductions/UXP/commit/a49d052 squashed into https://github.com/MoonchildProductions/UXP/commit/5dba1eb ) some minor "annoyances" are now present in the revamped aboutDialog box when Dark Moon is used/enabled:

DarkMoon

As I have highlighted via the red rectangles, the three (underlined) links (Pale Moon, Moonchild Productions, Pale Moon forum) now use white letters on a bright background, making them hard to read... Hovering over those links is even worse, as they turn to off-white/gray, fully merging with the background:

DarkMoon_HoverLink

Additionally, hovering over the (non-underlined) three links at the bottom (End-user rights, Licensing information, Release notes) makes them almost vanish:

DarkMoon_HoverLink2

I have tried myself to locate where exactly in the Dark Moon CSS code those changes are being authored, but, owing to my relative ignorance, I was unsuccessful in finding that code (is it inside "browser.css" file?) ๐Ÿ˜ž

For comparison, switching over to the default 28.5.0a1 theme I get:

DefaultTheme

where the "unhovered" links (not underlined) are in readable blue colour...

Of note is the fact that another of your Complete Themes, XMoon v1.10.0 , seems to exhibit the "desired" behaviour with the revamped aboutDialog box, i.e. the un-hovered links in question are underlined (I understand this is something you implement...) and in readable blue colour:

(XMoon v1.10.0) XMoon

I hope the issue reported in latest Dark Moon is one easily mitigated; genuinely thankful for your efforts ๐Ÿ‘ Best regards ๐Ÿ˜„