search

Lootyhoof / darkmoon

Dark theme for Pale Moon
Mozilla Public License 2.0
19 stars 6 forks source link

Icons of Navbar(?) not visible #4

Open RoestVrijStaal opened 5 years ago

RoestVrijStaal commented 5 years ago

Good evening,

I'm addressing an issue which I ran into for months, but today I was enough fed up of it to start digging in it.

The icons of the buttons westwards at the urlbar are not visible, and the "Downloads", "History" and "Bookmarks" buttons look "wrecked".

Take a look at the screenshots, made with a brandnew Pale Moon profile with only Dark Moon installed.

However, those icons appear when the menu-bar is disabled in favour of the big title button.

The bug seems to be Windows-only, since the problem isn't present on my Linux machine running Kubuntu 18.04.2 using Dark Breeze theme.

Used software in screenshot: Pale Moon 28.6.0.1 with Dark Moon 2.3.1

FullScreen_v1 0 0 HalfScreen_v1 0 0

Lootyhoof commented 5 years ago

I can't confirm this.

Dark Moon on Windows 7 (note: the above was taken in customize mode, to show all the buttons)

Dark Moon, menu bar disabled

Are your graphics drivers up to date? Curiously, does this also happen in White Moon?

RoestVrijStaal commented 5 years ago

Hello again,

My apologies for my late reply.

It also happened in White Moon. The problem still occurs after updating the video card drivers to the latest version.

However, I was able to eliminate the cause of the problem by creating a temporary Windows account.

It turns out the DPI settings are the cause. I've set the DPI of my daily driver's account to 105%, which results in the icons getting weird resizes which make them look "gone".

After some experimenting, I discovered the icons appear "normal" again at a DPI of 106%.

The interesting thing is that the phenomenon only occurs on Dark Moon and White Moon. Other (ported) themes you created like DarkPitch, Phoenity Rebirth, Moonfox3 and Fox 2 The Moon display the icons normally at every custom DPI setting.

Lootyhoof commented 5 years ago

I can confirm it, but not why this is happening. It's only on Windows 7, only in Aero mode.

You can workaround it by setting layout.css.devPixelsPerPx in about:config to 1.06 (106%) or similar. This only changes your browser DPI and not the system one.

I'm not certain of a solution at this time.

RoestVrijStaal commented 5 years ago

I notice at most of the other themes I tried (DarkPitch, Phoenity Rebirth, Moonfox3 and Fox 2 The Moon), the toolbar icons are embedded in a PNG file. DarkMoon and WhiteMoon have a ./src/chrome/browser/Toolbar.png in their repo, but it seems they don't use it. They use a chome://browser/skin/Toolbar.svg which seems to relate to ./src/chrome/browser/Toolbar.svg. Maybe the scaling of SVGs is an issue in Palemoon or even XUL? Please be aware: I've only used GitHub search function to lookup the usage of Toolbar.svg, Toolbar.png and its small/large variants.

Thanks for that workaround. I'll try that out soon, because the windows-userprofile-wide DPI setting of 106% initiated a different (but no workflow-breaking) "feeling" at other applications than Pale Moon.

Because there is as much as a half year left when Windows 7 is getting EOL and it seems like I'm the only person who's affected by the bug, I also doubt it's that worth fixing. For me, the workaround(s) of setting the DPI to 106% isn't much of a problem.

In case other persons also face the issue (I could imagine not every Linux distro or desktop environment plays nice with custom DPI), fixing this would have more added value.