search

Lootyhoof / darkmoon

Dark theme for Pale Moon
Mozilla Public License 2.0
19 stars 6 forks source link

"Download Status" icon missing in v2.5.0 ... #6

Closed Vangelis66 closed 4 years ago

Vangelis66 commented 4 years ago

Thanks anew for maintaining my preferred dark theme for the Pale Moon browser 🥇

My specifics:

OS: Windows 7 SP1 64-bit (Windows Aero enabled) Browser: Pale Moon, 32-bit Update channel: Unstable appVersion: 29.0.0a6 buildID: 20200827072427 Complete Theme used: Dark Moon 2.5.0 (latest)

Issue details:

The Download Status icon is AWAL in latest version of DM 2.5.0:

DarkMoon-2 5 0

This button is associated with the status-4-evar code that is native to Pale Moon; the button is there when the default browser theme is used:

Default

FWIW, previous version (2.4.2) of this complete theme does NOT manifest this bug:

DarkMoon-2 4 2

Hopefully, all this is just a simple omission, easy to mitigate... I'll stay myself at 2.4.2 until such time...

Thanks in advance, most kind regards 😄

Vangelis66 commented 4 years ago

UPDATE: It would appear that https://github.com/Lootyhoof/darkmoon/commit/0dec084 (Split statusbar styling per OS) is the culprit...

File src/chrome/browser/statusbar/overlay.css contained pre-commit the following CSS block: 

#status4evar-download-button #status4evar-download-icon {
    min-width: 18px;
    min-height: 18px;
}

that was somehow not transferred to the new "per OS" files... 😞

I modified locally file src/chrome/os/winnt/browser/statusbar/overlay.css to read:

/* Download status */

#status4evar-download-progress-bar {
   height: 4px;
}

#status4evar-download-button #status4evar-download-icon {
   min-width: 18px;
   min-height: 18px;
}

toolbar[mode="icons"] #status4evar-download-button[forcelabel="true"] > label {
   margin-inline-start: 5px !important;
}

/* Splitter */

... and that seems to have fixed it for me (on WinOS) 😄

Lootyhoof commented 4 years ago

Thanks for confirming this. I'll release an update soon with the fix.