feat: add Dockerfile - Githubissues

Trickfilm400 commented 5 months ago

Hi @Lopo,

finally, I got the build process working and here is the result: a Dockerfile for a docker image to run this project in a docker container.

I've also changed the installation instructions, because there were some errors in it, which resulted in installation errors, but the changed documentation works and this is what is used in the Dockerfile

PS: if you don't want the docker instructions in your repository due to limited maintenance time, I can also set up another repo and maintain the docker setup there and we can link to this repo from the offical one

Closes #3

If you have any questions, feel free to ask

Lopo commented 3 months ago

Hi @Trickfilm400,

sorry for a late response, but last weeks I have so much work , that I barely can do anything else.

For now, I don't have time to fully test your PR, so please set up another repo and I'll put link to it in the README File.

Trickfilm400 commented 3 months ago

I've created a repository here: https://github.com/Trickfilm400/limas-docker

You can link to this URL I think

I have the issue that after "login" (opening the page) I get the popup to run the setup immediately, but the database migration was directly before, so something is wrong with the code logic? Do you know this issue maybe?

Lopo commented 3 months ago

what's the message in popup exactly ? Isn't it about not running cronjobs ?

Trickfilm400 commented 3 months ago

Yes, the cronjob warning as well, but I get a browser alert with the following message: Your database schema is not up-to-date! Please re-run setup immediately! The database migration ran only seconds before, so this can't be the issue, or do you need to execute another php command maybe?

Lopo commented 3 months ago

ah, yeah, I know ... have fix already for it some time, just haven't time to release it, i'll commit it soon

Lopo commented 3 months ago

ok, schema problem should be fixed with commit d47da0dab56b65d730702d9007710ece815688a3 and commit 5e1d9af56730867098cfca14d7b9e07f4efb40f0 adds link to your docker repo

Trickfilm400 commented 3 months ago

perfect, the error is gone and thank you for the link in the readme (fun fact: if you mention my username with an "@", it's clickable :D and looks better)

Isn't it about not running cronjobs ?

Just for understanding: do you have this error message as well? Can I fix it or is it also a bug?

another question: should this PR be open until we merge this sometime in the future or should we close it?

Lopo commented 3 months ago

do you have this error message as well? Can I fix it or is it also a bug?

if u mean that msg about cron, than yes, I have it too I'm thinking how to solve it ... or "solve" :D

But for now, I think that PR can be closed. I have long time ago started work on docker (compose) , but no time to finish it. Will see if I finish it, or will just use that yours.

Trickfilm400 commented 3 months ago

if u mean that msg about cron, than yes, I have it too

okay great, I thought maybe I missed something

I'm thinking how to solve it ... or "solve" :D

I'm not into the code logic behind this, but for example nextcloud has an PHP file which is executed every 5 minutes via the crontab cronjob (Documentation: https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/background_jobs_configuration.html)

There are 2 real methods:

executing the file via crontab
on every page request, via an ajax request some cronjob is started (so every time the browser makes a request to some endpoint and this endpoint checks if something has to be done, just like a dedicated cron.php file via cronjob)

based on the needs either of them can be configured I think this concept could also be used here?

I have long time ago started work on docker (compose) , but no time to finish it. Will see if I finish it, or will just use that yours.

I mean it would be interessting to see if we have both the same things done or if one of us has a better implementation, so for me it would be nice to see yours to check, if I could learn some stuff of it, but I know that your time is limited, so yeah, it's also okay if this doesn't happen

I will close this now, but we can still write here (or creating a github discussion or whatever)

Lopo / Limas

feat: add Dockerfile #5