LopyLuna / Create-Dreams-and-Desires

Other
20 stars 25 forks source link

Create: Dreams and Desires causes a crash if the Zeta mod is installed. #95

Closed ProjectHSI closed 3 months ago

ProjectHSI commented 3 months ago

Create: Dreams and Desires causes a crash, as mentioned earlier. This happens since Zeta crawls through all registered recipes.

  1. Zeta begins crawling through recipes
  2. a call is made to GRHoeItem.getCraftingRemainingItem
  3. ItemStack's constructor reports an error of "Cannot invoke "net.minecraft.world.level.ItemLike.m5456()" because "p41604" is null" (accordings to mappings.dev, this crashes on the "AsItem()" function)
  4. The exception travels up the callstack, causing a crash, as Zeta didn't catch the exception.
ProjectHSI commented 3 months ago

Nevermind, this was fixed in https://github.com/LopyLuna/Create-Dreams-and-Desires/commit/8a0c592623fb0ab7b28b374301fded1e72720df9 and just hasn't been published to Modrinth.

LopyLuna commented 3 months ago

do not upload downloads of my mod without permission

ProjectHSI commented 3 months ago

do not upload downloads of my mod without permission

unsure what you mean by this? the files were a windows virus, not your mod from the latest commit on there

how do i know this, you may ask? i downloaded it to find out (cautiously, of course)

LopyLuna commented 3 months ago

rather be safe and judging by the context I think they did but if not and advertising that it is this mod I'd assume they put a virus in some form

ask permission first before uploading in general of the software and even the place where your uploading the software at

software as in mod, program, etc that involves with coding it

LopyLuna commented 3 months ago

sorry if I horribly explain it but it was for a good intention

LopyLuna commented 3 months ago

and due to the recent event with areo I'm bit more cautious too

ProjectHSI commented 3 months ago

rather be safe and judging by the context I think they did but if not and advertising that it is this mod I'd assume they put a virus in some form

ask permission first before uploading in general of the software and even the place where your uploading the software at

software as in mod, program, etc that involves with coding it

ok