Loqor / ait

Adds the TARDIS from Doctor Who that you can interact with in a new plethora of ways. Updated for Fabric 1.20.1.
GNU Lesser General Public License v3.0
19 stars 12 forks source link

Sonic Screwdrivers do not render in the sonic port on custom consoles. #306

Open rhamn0us opened 2 months ago

rhamn0us commented 2 months ago

Describe the bug Sonic Screwdrivers do not render on custom console textures.

To Reproduce Steps to reproduce the behavior:

  1. Have a custom console texture.
  2. Put the Sonic Screwdriver in the sonic port.

Screenshots

image

AIT Version: Latest Current Release.

Additional context This was purely AIT, no other mods installed.

Duzos commented 2 months ago

Changed via datapack?

rhamn0us commented 2 months ago

That's correct, it's a custom console texture from a datapack.

Duzos commented 2 months ago

I'm guessing datapack console variants reset the offset and rotation of the sonic

my suggestion to fix is to ensure

    public Vector3f sonicItemTranslations() {
        return new Vector3f(0.1f, 1.2f, 0.26f);
    }

    public float[] sonicItemRotations() {
        return new float[]{120f, 135f};
    }

are overwritten to match their parents in ClientConsoleVariantRegistry#convertDatapack