search

Lora-net / SWL2001

LoRa Basics Modem LoRaWAN stack
BSD 3-Clause Clear License
104 stars 60 forks source link

NotifyNewEndDeviceReq does not contain the MAC command ID #17

Closed adriansmares closed 9 months ago

adriansmares commented 1 year ago

When LBM is compiled with relay RX support, the relay can choose to notify the Network Server that an unknown end device has sent a wake-on-radio frame. The current LBM implementation achieves this by sending an uplink on FPort=0, which is fine, but the payload is not prepended by the MAC command ID, which makes parsing on the Network Server not possible.

https://github.com/Lora-net/SWL2001/blob/c4f386ac54b3e35f45b8ba7502207faa6f634921/smtc_modem_core/lr1mac/src/relay/relay_rx/relay_rx.c#L1304-L1332

Notice that the first element in the buffer is related to the device address of the unknown device, not the MAC command ID (which is decimal 70).

image

It is also the case that this implementation cannot piggy-back an existing uplink (via FOpts), but that's another problem.

lbm-team commented 9 months ago

Hello,

This issue was solved in the release v4.4.0-feature-relay.