Lora-net / SWL2001

LoRa Basics Modem LoRaWAN stack
BSD 3-Clause Clear License
88 stars 52 forks source link

modem_status description not consistent #4

Closed Joe-Hu-Chat closed 1 year ago

Joe-Hu-Chat commented 2 years ago

modem_status description in modem_context.c seems not consistent with device_management_defs.h.

See the capture below for more details. In modem_context.c

/*!
 * \brief   return the modem status
 * \remark
 * \param [IN] void
 * \param [OUT] modem status bit 6 : streaming in progress
 *                           bit 5 : file upload in progress
 *                           bit 4 : radio suspend
 *                           bit 3 : modem join
 *                           bit 2 : modem mute
 *                           bit 1 : reset after panic
 *                           bit 0 : reset after brownout
 * */

In device_management_defs.h:

/*!
 * \typedef e_modem_status_t
 * \brief   Modem Status
 */
typedef enum e_modem_status
{
    modem_status_brownout  = 0,  //!< reset after brownout
    modem_status_crash     = 1,  //!< reset after panic
    modem_status_mute      = 2,  //!< device is muted
    modem_status_joined    = 3,  //!< device has joined network
    modem_status_suspend   = 4,  //!< radio operations suspended (low power)
    modem_status_upload    = 5,  //!< file upload in progress
    modem_status_joining   = 6,  //!< device is trying to join the network
    modem_status_streaming = 7   //!< streaming in progress
} e_modem_status_t;

modem_context.c device_management_defs.h

smtc-bot commented 1 year ago

Thank you for your inquiry.

Customers are encouraged to submit technical questions via our dedicated support portal at https://semtech.force.com/ldp/ldp_support.

We invite all users to visit the LoRa Developer Portal Forum at https://forum.lora-developers.semtech.com and to join the thriving LoRa development community!