Lora-net / SWL2001

LoRa Basics Modem LoRaWAN stack
BSD 3-Clause Clear License
104 stars 60 forks source link

Example application overrides EUIs while using LR11xx crypto #6

Closed adriansmares closed 1 year ago

adriansmares commented 1 year ago

The example application overrides the DevEUI/JoinEUI and AppKey always on reset: https://github.com/Lora-net/SWL2001/blob/0979db31e5daedbcd7bef20d699dfda1efa6b307/utilities/user_app/main_examples/main_exti.c#L200-L211

This should be a bit more nuanced, since if the example is compiled with CRYPTO=LR11XX_WITH_CREDENTIALS, one may expect that the EUIs are really the ones 'on the board'. Maybe the overrides should be guarded by a ifdef for USE_PRE_PROVISIONED_FEATURES ?

smtc-bot commented 1 year ago

Thank you for your inquiry.

Customers are encouraged to submit technical questions via our dedicated support portal at https://semtech.force.com/ldp/ldp_support.

We invite all users to visit the LoRa Developer Portal Forum at https://forum.lora-developers.semtech.com and to join the thriving LoRa development community!

matthieuantoine commented 1 year ago

Thanks @adriansmares - I'll report that internally to update it for the next release.

FYI - examples in the LoRa Basics Modem SDK already have it implemented this way.

lbm-team commented 1 year ago

Hi @adriansmares ! Thanks for your report. We will update the basic example to take in count internal credentials in case CRYPTO=LR11XX_WITH_CREDENTIALS is used at makefile level.
It can also make sense to print current CHIP EUI and CHIP PIN to ease claiming process.
It will be updated as well for the next release

lbm-team commented 1 year ago

Hi @adriansmares !

We add this feature in the new v3.3.0 release.
You can find the updates line in main example here