fix(mcu): endianness aware mcu command structure

Lora-net / picoGW_hal

Host driver/HAL to build a LoRa Picocell Gateway which communicates through USB with a concentrator board based on Semtech SX1308 multi-channel modem and SX1257/SX1255 RF transceivers.

Other

45 stars 47 forks source link

fix(mcu): endianness aware mcu command structure #8

Closed faryon93 closed 2 years ago

faryon93 commented 5 years ago

Currently only little-endian hosts are supported because of the way multi-byte values get transferred to the MCU. Running libloragw on big-endian hosts is therefore a problem.

ecsv commented 3 years ago

@Lora-net @mcoracin Any chance to merge this? I've just ran into the same problem and debugged the rx/tx paths until noticing the same problem in lgw_mcu_rxrf_setconf. Only noticed it by pure luck that @faryon93 published his fix (thanks btw).

smtc-bot commented 2 years ago

Thank you for your inquiry.

Customers are encouraged to submit technical questions via our dedicated support portal at https://semtech.force.com/ldp/ldp_support.

We invite all users to visit the LoRa Developer Portal Forum at https://forum.lora-developers.semtech.com and to join the thriving LoRa development community!

ecsv commented 2 years ago

These are bugfixes and not technical questions.

vtjballeng commented 2 years ago

@mcoracin I believe this needs review and a likely merge if not already resolved as it's validated by two parties across years of time.