Lord-Akkrand / Skyrim-NX-Toolkit

A set of scripts to convert mods from Skyrim SE to Skyrim NX
MIT License
71 stars 1 forks source link

Reason for removing files within *.esm/*.esp folder among loose files? #49

Open x43x61x69 opened 3 years ago

x43x61x69 commented 3 years ago

As title, I've noticed the tool by default will remove any folder named *.esm/*.esp within the meshes and texture folder (e.g. under facegendata/facegeom) in pack_mod.py.

Are those files unsupported? Many MODs were used to patch another existing MOD, which would require to have those file otherwise they won't do anything.

Lord-Akkrand commented 3 years ago

Doesn't it put them in a differently named folder, to match what's being packed? I'm sure I remember there being a reason for this, although I honestly haven't looked at the code in a couple of years

On Mon, 29 Mar 2021, 3:33 am ZW Cai, @.***> wrote:

As title, I've noticed the tool by default will remove any folder named .esm/.esp within the meshes and texture folder (e.g. under facegendata/facegeom) in pack_mod.py.

Are those files unsupported? Many MODs were used to patch another existing MOD, which would require to have those file otherwise they won't do anything.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Lord-Akkrand/Skyrim-NX-Toolkit/issues/49, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEZMAI3NNJKKLXEYL3EL46TTF5K6JANCNFSM4Z6GG57Q .

x43x61x69 commented 3 years ago

I’ve encountered a MOD that has 800MB of NIF and DDS but only within those .esp folders. After the conversation, it generated no BSA file and the log shown they were deleted even tho they were converted. I googled but didn’t find the exact reason why they were removed. If those .esp folders were for game default ones such as Skyrim.esm, that could make sense, but if it’s for another 3rd party MOD, removing them seems making no sense unless Switch version does not support such replacement.

Lord-Akkrand commented 3 years ago

Did you have the mods esp file in the same directory as the original BSA? Or, if the mod came with loose files instead of a BSA, the esp file needs to be in the root folder. Otherwise, the packer doesn't see anything that will load those files, so it deletes them.

On Mon, 29 Mar 2021, 5:20 pm ZW Cai, @.***> wrote:

I’ve encountered a MOD that has 800MB of NIF and DDS but only within those .esp folders. After the conversation, it generated no BSA file and the log shown they were deleted even tho they were converted. I googled but didn’t find the exact reason why they were removed. If those .esp folders were for game default ones such as Skyrim.esm, that could make sense, but if it’s for another 3rd party MOD, removing them seems making no sense unless Switch version does not support such replacement.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Lord-Akkrand/Skyrim-NX-Toolkit/issues/49#issuecomment-809102591, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEZMAIYJMLWAYOPDSJ6SEHDTGALZ3ANCNFSM4Z6GG57Q .

x43x61x69 commented 3 years ago

Yes I did, and I knew that they will be removed if there's no reference to them (however I do think there should be an option for the user to decide if they want to do simple packing instead, as for Switch it's much easier to pack loose files into BSAs for managing and load order between plugins). Here's one of the examples, which use loose files. After converting, there'll be no BSA created as they were all in the .esp/.esp folders.

There are some other examples, where the original PC BSA has files within the BSA under the .esp/.esm folder and got completely removed after converted, cause the facegen data to be missing.

Thanks again for all your hard work.