Lord-Kamina / Deluge-Magnet-Handler

OSX Applescript handler to open magnet URLs in Deluge.app
Other
90 stars 6 forks source link

Does indeed work (edited) #1

Open hinderaker opened 8 years ago

hinderaker commented 8 years ago

Plugin of the year, if it only worked ... Program starts (no visible UI) then closes again after 2-3 seconds on OS X 10.11.1 running Deluge 1.3.12.

Lord-Kamina commented 8 years ago

There is no visible UI, the script is essentially just an AppleScript wrapper. I have the same setup as you and it works perfectly. Are you sure magnet uris are correctly associated with it? (Probably requires RCDefaultApp prefpane) and that Deluge is properly located in /Applications? (I frankly cannot remember if I added something to try and locate the app elsewhere)

Other things you might try is checking the console, running the plug-in in Script Editor and supplying a test magnet to test its behavior (although I suspect it has more to do with configuration than the actual script, as it's exceedingly simple)

hinderaker commented 8 years ago

Hello again,

With regards to the README I was under the impression that I would have to open magnet handler and then associating it from there. My bad. Using RCDefaultAPP it all works out great.

Thanks man :)

Lord-Kamina commented 8 years ago

Ok, that's it, I really need to update that README I guess.

edit: fixed.

On Fri, Dec 4, 2015 at 6:38 PM, Glenn M. Hinderaker < notifications@github.com> wrote:

Hello again,

With regards to the README I was under the impression that I would have to open magnet handler and then associating it from there. My bad. Using RCDefaultAPP it all works out great.

Thanks man :)

— Reply to this email directly or view it on GitHub https://github.com/Lord-Kamina/Deluge-Magnet-Handler/issues/1#issuecomment-162089233 .

Gregorio Litenstein Goldzweig [image: glit_qr.png] Interno de Medicina Facultad de Medicina Clí­nica Alemana - Universidad del Desarrollo

Lord-Kamina commented 8 years ago

I'm just re-opening this because I just updated the app so it should be able to function on its own, without RCDefaultApp.

anigupta commented 5 years ago

I tried to install it. The application shows you the various alerts, permissions given in sys pref, but doesn't associate magnet links with Deluge. Still associated with uTorrent. OSX 10.14.2

Lord-Kamina commented 5 years ago

Hmm it works fine for me but I haven't tried to associate it from scratch on Mojave. Will try to reproduce and get back to you on this.

Lord-Kamina commented 5 years ago

@anigupta I have confirmed this issue; I assume it has something to do with Mojave's new AppleScript security requirements. Until I can figure out how to fix it (or if it even can be fixed without rewriting the entire app in Swift), you can manually run the helper app to associate the Magnet Handler and then check association was successful.

Open a terminal and type (assuming default locations, obviously):

cd /Applications/Magnet\ Handler.app/Contents/Resources/
./registerHandler -register
./registerHandler -check

If successful, the second command should output org.deluge.magneturihandler

anigupta commented 5 years ago

@Lord-Kamina that worked! I did as you asked and now magnet links open in deluge 👍 Thanks!

Lord-Kamina commented 5 years ago

@anigupta I think I've managed to squash the bug and made a new release with a few changes. Could you test version 1.3.0 by manually changing magnets to some other app and then runnng Magnet Handler.app normally as specified in the README.md?

adamgarbo commented 5 years ago

@Lord-Kamina I can confirm that the version 1.3.0 works on a new macOS Mojave installation. Thanks for your work!

anigupta commented 5 years ago

hi, has something changed? There is no .app file anymore in the bundle. How does one install this now?

adamgarbo commented 5 years ago

@anigupta I had the same question! I struggled to find it until I sheepishly realized you just need to click on Releases.

Lord-Kamina commented 5 years ago

I was somewhat new to github when I started this and didn't really understand how it worked. I've fixed that. You should download the binary from the releases tab:

https://github.com/Lord-Kamina/Deluge-Magnet-Handler/releases/tag/1.3.0

anigupta commented 5 years ago

Got it. Works now. Thanks!!