search

LordAmit / Brightness

Using Brightness Controller, you can control brightness of both primary and external displays in Linux. Check it out!
Other
1.06k stars 84 forks source link

Close the application when moving the monitor off slider #218

Open bohorok opened 2 years ago

bohorok commented 2 years ago

Describe the bug I have two monitors connected. One LVDS, the other VGA. I display the image on VGA, and LVDS is turned off by software. When I try to move the brightness slider of the off monitor, the application closes.

Expected behavior It seems to me that the application should not close when the monitor is turned off.

Screenshots

Desktop (please complete the following information):

Additional context

Screen 0: minimum 8 x 8, current 1280 x 1024, maximum 32767 x 32767
LVDS1 connected primary (normal left inverted right x axis y axis)
   1366x768      60.02 +
   1280x720      59.86    60.00    59.74  
   1024x768      60.00  
   1024x576      60.00    59.90    59.82  
   960x540       60.00    59.63    59.82  
   800x600       60.32    56.25  
   864x486       60.00    59.92    59.57  
   640x480       59.94  
   720x405       59.51    60.00    58.99  
   680x384       60.00  
   640x360       59.84    59.32    60.00  
DP1 disconnected (normal left inverted right x axis y axis)
DP2 disconnected (normal left inverted right x axis y axis)
DP3 disconnected (normal left inverted right x axis y axis)
HDMI1 disconnected (normal left inverted right x axis y axis)
HDMI2 disconnected (normal left inverted right x axis y axis)
HDMI3 disconnected (normal left inverted right x axis y axis)
VGA1 connected 1280x1024+0+0 (normal left inverted right x axis y axis) 380mm x 300mm
   1280x1024     60.02*+  75.02  
   1280x960      60.00  
   1152x864      75.00  
   1024x768      75.03    70.07    60.00  
   832x624       74.55  
   800x600       72.19    75.00    60.32    56.25  
   640x480       75.00    72.81    66.67    59.94  
   720x400       70.08  
VIRTUAL1 disconnected (normal left inverted right x axis y axis)
archisman-panigrahi commented 2 years ago

Are you using the latest source? The AUR package is out of date.

Please install from pip/run from source in case you didn't, and let us know if the issue persists.

On Sun, 2 Oct, 2022, 1:10 pm bohorok, @.***> wrote:

Describe the bug I have two monitors connected. One LVDS, the other VGA. I display the image on VGA, and LVDS is turned off by software. When I try to move the brightness slider of the off monitor, the application closes.

Expected behavior It seems to me that the application should not close when the monitor is turned off.

Screenshots

Desktop (please complete the following information):

  • archlinux
  • de: xfce

Additional context

Screen 0: minimum 8 x 8, current 1280 x 1024, maximum 32767 x 32767 LVDS1 connected primary (normal left inverted right x axis y axis) 1366x768 60.02 + 1280x720 59.86 60.00 59.74 1024x768 60.00 1024x576 60.00 59.90 59.82 960x540 60.00 59.63 59.82 800x600 60.32 56.25 864x486 60.00 59.92 59.57 640x480 59.94 720x405 59.51 60.00 58.99 680x384 60.00 640x360 59.84 59.32 60.00 DP1 disconnected (normal left inverted right x axis y axis) DP2 disconnected (normal left inverted right x axis y axis) DP3 disconnected (normal left inverted right x axis y axis) HDMI1 disconnected (normal left inverted right x axis y axis) HDMI2 disconnected (normal left inverted right x axis y axis) HDMI3 disconnected (normal left inverted right x axis y axis) VGA1 connected 1280x1024+0+0 (normal left inverted right x axis y axis) 380mm x 300mm 1280x1024 60.02*+ 75.02 1280x960 60.00 1152x864 75.00 1024x768 75.03 70.07 60.00 832x624 74.55 800x600 72.19 75.00 60.32 56.25 640x480 75.00 72.81 66.67 59.94 720x400 70.08 VIRTUAL1 disconnected (normal left inverted right x axis y axis)

— Reply to this email directly, view it on GitHub https://github.com/LordAmit/Brightness/issues/218, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXL2XGPVI7AX3KOQQ2LSITWBG6XVANCNFSM6AAAAAAQ27L2HE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

bohorok commented 2 years ago

i have version 2.4 installed with pip command

Name: brightness-controller-linux
Version: 2.4
Summary: Using Brightness Controller, you can control brightness of both primary and external displays in Linux. Check it out!
Home-page: https://github.com/LordAmit/Brightness
Author: Amit
Author-email: lordamit@gmail.com
License: None
Location: /home/khamsin/.local/lib/python3.10/site-packages
Requires: PyQt5, QtPy
Required-by:
LordAmit commented 2 years ago

So, let me know if I got the exact steps right:

  1. Start brightness controller
  2. Turn off LVDS1 display using an external software
  3. Change brightness/values associated with LVDS1

And then Brightness Controller crashes.

Please confirm.

bohorok commented 2 years ago

I updated the system to eliminate the cause of outdated packages. Scenario 1 Second monitor: VGA-active, primary monitor: LVDS-disabled by software.

  1. Start BC (brightness controller).
  2. Adjusts the parameters of the VGA-active monitor with sliders (backlight, R, G, B), everything works.
  3. I click close and the BC icon appears in the tray.
  4. Adjusts the parameters of the LVDS-inactive monitor with sliders (backlight, R, G, B), clicking on any slider closes the application.
  5. The icon also disappears from the tray.

Scenario 2 Second monitor: VGA-disabled by software, primary monitor: LVDS-active. All the same as in scenario 1.

Scenario 3 Second monitor: VGA-active, primary monitor: LVDS-active (extended to right).

  1. Start BC (brightness controller).
  2. Adjusts the parameters of the both active monitors with sliders (backlight, R, G, B), everything works.
  3. I click close and the BC icon appears in the tray.

In my opinion, the turned off screen should be detected and its sliders should be inactive.

LordAmit commented 2 years ago

Got it! Thanks for the detailed steps!

What do you use to turn off/disable the monitor? This part is important, since as you probably noticed in the xrandr output, LVDS1 and VGA1 are both showing connected, and nothing is indicating that one of them is disabled.

bohorok commented 2 years ago

I use xfce4-display-settings, I also tested arandr. here is the result of the 'xrandr -q' command after disconnecting the VGA plug:

Screen 0: minimum 8 x 8, current 1366 x 768, maximum 32767 x 32767
LVDS1 connected primary 1366x768+0+0 (normal left inverted right x axis y axis) 280mm x 160mm
   1366x768      60.02*+
   1280x720      59.86    60.00    59.74  
   1024x768      60.00  
   1024x576      60.00    59.90    59.82  
   960x540       60.00    59.63    59.82  
   800x600       60.32    56.25  
   864x486       60.00    59.92    59.57  
   640x480       59.94  
   720x405       59.51    60.00    58.99  
   680x384       60.00  
   640x360       59.84    59.32    60.00  
DP1 disconnected (normal left inverted right x axis y axis)
DP2 disconnected (normal left inverted right x axis y axis)
DP3 disconnected (normal left inverted right x axis y axis)
HDMI1 disconnected (normal left inverted right x axis y axis)
HDMI2 disconnected (normal left inverted right x axis y axis)
HDMI3 disconnected (normal left inverted right x axis y axis)
VGA1 disconnected (normal left inverted right x axis y axis)
VIRTUAL1 disconnected (normal left inverted right x axis y axis)

And this is the result of the same command when both monitors are physically connected, but only LVDS is marked as active:

Screen 0: minimum 8 x 8, current 1366 x 768, maximum 32767 x 32767
LVDS1 connected primary 1366x768+0+0 (normal left inverted right x axis y axis) 280mm x 160mm
   1366x768      60.02*+
   1280x720      59.86    60.00    59.74  
   1024x768      60.00  
   1024x576      60.00    59.90    59.82  
   960x540       60.00    59.63    59.82  
   800x600       60.32    56.25  
   864x486       60.00    59.92    59.57  
   640x480       59.94  
   720x405       59.51    60.00    58.99  
   680x384       60.00  
   640x360       59.84    59.32    60.00  
DP1 disconnected (normal left inverted right x axis y axis)
DP2 disconnected (normal left inverted right x axis y axis)
DP3 disconnected (normal left inverted right x axis y axis)
HDMI1 disconnected (normal left inverted right x axis y axis)
HDMI2 disconnected (normal left inverted right x axis y axis)
HDMI3 disconnected (normal left inverted right x axis y axis)
VGA1 connected (normal left inverted right x axis y axis)
   1280x1024     60.02 +  75.02  
   1280x960      60.00  
   1152x864      75.00  
   1024x768      75.03    70.07    60.00  
   832x624       74.55  
   800x600       72.19    75.00    60.32    56.25  
   640x480       75.00    72.81    66.67    59.94  
   720x400       70.08  
VIRTUAL1 disconnected (normal left inverted right x axis y axis)

It seems that the connected status only says about attaching a physical monitor to the system. Active monitors returns a command: "xrandr --listmonitors". It's results this command (only LVDS active):

Monitors: 1
 0: +*LVDS1 1366/280x768/160+0+0  LVDS1