Open MartinSkold opened 7 months ago
See I2C Device Permissions section in https://www.ddcutil.com/config_steps/
Hi @archisman-panigrahi
I'm experiencing a similar problem and I think it might be a bug :thinking:
This is the output that I get when I run the ddcutil detect
command for the first time with the correct permissions.
And then, as you can see, the built-in display is no longer detected.
So after this happens, from what I understand of the implementation, xrandr
is used to detect the number of displays, and when I run the xrandr --query
command, as it is used here I correctly get two displays connected.
So, I suspect that during the init of the app, xrandr
detects two displays but ddcutil
only one, so when the following variable is filled, it contains two displays.
https://github.com/LordAmit/Brightness/blob/dab46e312e04948b8a4286de169782bde43c6032/brightness-controller-linux/brightness_controller_linux/init.py#L50-L52
Finally, when it reaches the following line, an error is thrown since the self.displayNames
comes from ddcutil
output not from xrandr
.
https://github.com/LordAmit/Brightness/blob/dab46e312e04948b8a4286de169782bde43c6032/brightness-controller-linux/brightness_controller_linux/init.py#L281-L284
This is the error that I see on the logs.
If needed I can create a separate issue for this. Thank you very much for your work!
@thardev Thanks for the bug report! Can you also try my fork? https://github.com/Soggy-Pancake/Brightness-Direct-Control I just made some changes that should hopefully fix the problem.
The problem was that in CDisplay.match_ddc_order it was failing to add the laptop display and it was still counted so it then tried to load the reordered names missing the laptop display.
I also added several other patches since my last pull request that improves the ddcutil mode.
Hi @Soggy-Pancake
Thank you for your answer 🙂 I did try your fork but I don't seem to be able to make it work properly, I've followed the instructions of this README https://github.com/Soggy-Pancake/Brightness-Direct-Control/blob/master/brightness-controller-linux/README.md but the app crashes when I try to adjust the brightness. Probably I need to install it system wide properly? Or what else could it be?
What is the traceback when it crashes?
DDCutil needs to be installed if you are using direct backlight control but you should be able to run the brightness controller from any location.
@thardev Can you please provide the traceback for the crash when attempting to change brightness?
I installed it, installed ddcutil using
sudo apt install ddcutil
, but the application crashes at start. Is there some permissions I need to set?Version brightness-controller-linux==2.4
To Reproduce Steps to reproduce the behavior:
starting app with
brightness-controller
in terminalExpected behavior Not a index out of range?
Desktop (please complete the following information):
Running on a Dell Inc. Precision 5560
Additional context Am I missing any instructions?