search

LordAshes / TaleSpire-GrabDropPlugin

Unofficial TaleSpire plugin for grabbing and dropping prop minis
MIT License
1 stars 2 forks source link

Deleting a Grabber disabled token selection #1

Open demongund opened 3 years ago

demongund commented 3 years ago

If you delete a token which has grabbed another, you can no longer select other tokens. Navigating to another board and coming back fixes the issue.

  1. Create giant rat token
  2. Create another
  3. Have the 1st rat grab the 2nd
  4. Delete the first

Notice

LordAshes commented 3 years ago

Noted. However, I am not sure there is much I can do about this because it would require intercepting the TS core delete function before it occurs.

However, I am not sure why the "can no longer select tokens" issue occurs.

Lord Ashes

On Fri, Jul 2, 2021 at 12:57 AM demongund @.***> wrote:

If you delete a token which has grabbed another, you can no longer select other tokens. Navigating to another board and coming back fixes the issue.

  1. Create giant rat token
  2. Create another
  3. Have the 1st rat grab the 2nd
  4. Delete the first

Notice

  • Both rats are removed ** The second rat (which should not have been removed) will re-appear if you navigate to another board and come back.
  • The cursor can no longer select other tokens

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LordAshes/TaleSpire-GrabDropPlugin/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGQ5Y6DOX3HRTKEFOQYKHITTVVBKTANCNFSM47V7HBWQ .

demongund commented 3 years ago

Could you tweak the Radial UI to disable the Kill option?

LordAshes commented 3 years ago

Not yet. I believe Hollo is working on giving access to removing core TS menu entries but it is not available yet. Once Radial UI plugin includes that feature, it will be possible to update Grab/Drop plugin.

Lord Ashes

On Fri, Jul 2, 2021 at 12:54 PM demongund @.***> wrote:

Could you tweak the Radial UI to disable the Kill option?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LordAshes/TaleSpire-GrabDropPlugin/issues/1#issuecomment-873132271, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGQ5Y6EXHWRBNXZF62XKMWLTVXVLJANCNFSM47V7HBWQ .

AlbrechtWM commented 3 years ago

@demongund Fixed, and pending a review from LordAshes. The solution did involve Hollo's changes to allow replacing the existing Creature -> Kill functionality with something custom. If you delete a creature that has grabbed other creatures now, it gracefully releases the grab on the other creatures before being deleted.

demongund commented 3 years ago

@AlbrechtWM Awesome! :D thanks so much! I'll test it out after it goes live!