LordDarthDan / Unvalkyried-Heavens

An unofficial compatibility fork of Valkyrien Skies - moving structures powered by a custom multi-threaded physics engine; in Minecraft.
https://valkyrienskies.org/
Apache License 2.0
1 stars 0 forks source link

Ghost Block Issue w/ Just VSkies installed #8

Open NoahJRalph opened 3 months ago

NoahJRalph commented 3 months ago

Howdy Darth!

I've noticed recently that VSkies, both your fork and the main version at no fault of your own, create a sizeable ghost block issue, where if you mine too quickly with an efficiency 5 tool, blocks will be removed visually client-side, but won't be removed server-side, causing players to suffocate when mining normally.

I've ran tests with only VSkies installed on a vanilla 1.12.2 forge setup in SP, as well as tested with our full normal pack of mods installed in a SP world, Messenger's Return 2, with and without VSkies just to make sure.

If you have any idea what might be causing this, I'd love to hear your thoughts!

LordDarthDan commented 3 months ago

Howdy Noah!

Pardon the delay. I typically get such issues on servers that are sufficiently far from me, with or without Valkyrien, and I'm generally used to them on servers, but you mentioning them on singleplayer is definitely interesting... Besides, knowing your dedication to making your packs run smoothly, I imagine there can be no user error in this.

Would you be willing to run a profiler (like Spark) while reproducing the ghost block issue? It could give me an idea on what functions specifically are slowed down in the desync process.

I'll point it out right now - I am no expert in netcode, so I do not promise a solution. But I'd gladly explore the options.