LordDeatHunter / FabricWaystones

A Fabric mod for Minecraft that adds waystones - a new way of transportation, that let you teleport from one discovered waystone to another.
MIT License
34 stars 66 forks source link

Inject waystones into Repurposed Structures zombie variant villages #229

Closed TelepathicGrunt closed 1 year ago

TelepathicGrunt commented 1 year ago

Will resolve https://github.com/LordDeatHunter/FabricWaystones/issues/227

Background, a user had a terrible giant lagspike with a Waystones mod on. Upon long investigation, the issue turned out that because the JSON files I added to Waystones mods have the Waystone piece marked as required and is injected into the non-zombie house piece, Repurposed Structures attempting to spawn a zombie variant village will keep retrying up to 100 times to find a zombie village layout that has the Waystone piece that it'll never have https://github.com/TelepathicGrunt/RepurposedStructures/issues/306

This issue affects 1.19.2 and 1.20.1. I already released a fix on my end for both versions by now rerolling the start piece if redoing the layout and lowered the retrying to 40 attempts. The side-effect of this fix means zombie villages won't spawn with Waystones mods on. This PR adds the Waystones pieces to the zombie village's house pools so now zombie villages can spawn with Repurposed Structures on again and can have a Waystone piece. (Note, Mushroom and Ocean do not have separate zombie variants. If backporting to 1.19.2, do not include Cherry and Bamboo as they are 1.20.1 exclusives)