search

LordDeatHunter / FabricaeExNihilo

Fabricate from nothing
MIT License
11 stars 9 forks source link

Do not issue a DDOS attack from strainers or barrels #62

Closed burdoto closed 7 months ago

burdoto commented 7 months ago

This is a band-aid solution for #55. That issue has been effectively DDOSing our servers; and since the report is already 8 months old with no update whatsoever, we only have the option to include dirty patches for it or remove FEN entirely. We'd like to keep it; so this is a dirty fix to the already dirty implementation. LOL.

burdoto commented 7 months ago

The fix is incomplete, as for our scenario, it seems to only delay and split lag spikes apart.

MattiDragon commented 7 months ago

I just yesterday pushed a commit fixing this. I still want to a bit of checking, but this should reduce packet spam from blocks that are ticking without any visual updates. I can probably get rid of even more packets by handling some actions on the client as well as the server.

burdoto commented 7 months ago

alright thats wonderful to hear; i didnt see that change. that obsoletes this bandaid solution