search

LordDeatHunter / FabricaeExNihilo

Fabricate from nothing
MIT License
11 stars 9 forks source link

(initial) 1.20.6 port #65

Closed imreallybadatnames closed 6 months ago

imreallybadatnames commented 6 months ago

Title. Largely untested, save for some sparse recipe tests (sieve, crucible, witch water) Has to be thoroughly tested before merging.

imreallybadatnames commented 6 months ago

The code also needs some inspection as well as cleanup. May be refactored.

imreallybadatnames commented 6 months ago

Seems fine now. Undrafting.

imreallybadatnames commented 6 months ago

I have initially implemented registry access via the lookup due to concerns regarding registry entry access issues I encountered quite some time ago in datagen in an unrelated mod, namely the registries being strangely empty, though I have not tested whether this is the case for this mod.

imreallybadatnames commented 6 months ago

I will revert the lookup changes once I verify that the original approach does not incur any issues during datagen.

imreallybadatnames commented 6 months ago

Turns out this doesn't work now due to some initialization weirdness regarding ToolType (enum values are initialized with null serializers and types)

imreallybadatnames commented 6 months ago

Fixed.