search

LordGrimmauld / windowlogging

Port of Creates windowlogging feature
MIT License
4 stars 8 forks source link

Crash w/ Double Slabs Mod #1

Closed WenXin20 closed 3 years ago

WenXin20 commented 4 years ago

Minecraft v1.15.2 Forge v31.2.36 Windowlogging v0.0.1 Double Slabs v2.11.7

If I add the doubleslabs:vertical_slab to the windowable tag, I will be able to combine a glass pane with the vertical slabs, but the vertical slab will then have a missing texture. If I then break the glass pane, the vertical slab changes to an Air Vertical Slab, which can crash the game. Is proper compatibility possible? Crash Report

LordGrimmauld commented 4 years ago

I need to save the windowlogged blocks NBT. That would fix similar issues with "Snow! Real magic" where windowlogged slabs/walls/stairs default to accacia. As for the rendering with a missing texture, i will try to fix it, though that might be more difficult. There is a reason why i did not put vertical slabs in the default config. I will try to fix it, we will see how successful i am with that.

WenXin20 commented 4 years ago

Thanks for looking into this!

LordGrimmauld commented 4 years ago

Ok, this issue should be fixed in the new 1.15.2 release at https://www.curseforge.com/minecraft/mc-mods/windowlogging/files/3060621 However, i could not figure out how to fix it on 1.16, as something behaves differently there.

WenXin20 commented 4 years ago

Thanks, I'll give it a try soon. Does this release also fix windowlogged fences not connecting?

WenXin20 commented 4 years ago

No more crashes, and the slab displays properly, but if I mine the vertical slab while it is windowlogged, it won't drop anything and doesn't make a breaking sound.

LordGrimmauld commented 4 years ago

hmm, ok. That with the sound i have no idea how to fix, in theory it should just work. That part with the drops is interesting, i might have to look further into that. For now, i am happy i got the crash and rendering fixed.

Spiderach commented 1 year ago

crash-2023-08-03_01.20.58-client.txt It appears that this bug may have returned as of 1.18.2. Rendering on Double Slab's vertical slabs fails if they're windowlogged, and it can cause client crashes again.