search

LordGrimmauld / windowlogging

Port of Creates windowlogging feature
MIT License
4 stars 8 forks source link

Mod compatibility with Pain in the Glass #15

Closed HopsandBarley closed 2 years ago

HopsandBarley commented 3 years ago

I have both Pain in the Glass and Windowlogging installed.

Pain in the Glass gives you the flexibility to place Panes on 'edges' and 'corners' of blocks, rather than always in the middle.

When i try to 'windowlog' PITG panes, the do not render in the game. they are invisible.

I don't know if this is a problem with PITG or Windowlogging, so I'm putting this comment in both places. Thanks! Two really nice and creative mods.

MongoTheElder commented 3 years ago

Hi! I'm the author of Pane In The Glass (PITG). The underlying issue is I use the _forge:glasspane tag so my panes can be used in crafting recipes but they are not compatible with your mod. PITG panes are not derived from either PaneBlock or FourWayBlock and require blockstates to determine which orientation to render.

Is there a way you can add a test to make sure the pane block is derived from FourWayBlock as a secondary way to filter out non-compatible blocks?

LordGrimmauld commented 2 years ago

I implemented a simple instanceof, this should be fine now