search

LordGrimmauld / windowlogging

Port of Creates windowlogging feature
MIT License
4 stars 8 forks source link

Minecraft 1.18.1 - bug - Corner connected stairs disconnect when windowlogged and reappear when not #22

Open DWX12 opened 2 years ago

DWX12 commented 2 years ago

Found a weird bug in version: windowlogging-mc1.18.1_v0.0.8

Testing out window logging and came across weird bug. When a pane is placed/logged in a stair next to one that is sideways and connected to form a corner piece, the connection is broken. If the logged pane is broken then the stairs reconnect. However, if the corner connected stair is logged with a pane then connected with another logged pane in the stair next to it then no bug will occur.

2022-03-15_02 10 06 2022-03-15_02 10 17 2022-03-15_02 10 58

Steps to reproduce:

  1. Place two stairs next to each other so that one is sideways and forms a corner piece
  2. Place a glass pane inside the non-corner piece
  3. Corner piece should disconnect
  4. Break window logged pane and connected stair should turn back into a corner piece

If you need me to provide any other information please let me know.

Many thanks for creating this cool decorative mod.

DomezTheDragon commented 2 months ago

i think it's because of how windowlogged blocks are handled, it doesnt modify the stair, it actually creates a block, then puts the window model in, then the stair model in, so you basically have to do the corners first as a sort of workaround, not really gamebreaking tho image

DomezTheDragon commented 2 months ago

image image i decided to pull open IBE editor to see the data structure