search

LordMathis / hugo-theme-nightfall

Minimal dark theme for Hugo
https://hugo-theme-nightfall.netlify.app/
MIT License
86 stars 45 forks source link

Not working disabled metadata #40

Open renanbastos93 opened 6 months ago

renanbastos93 commented 6 months ago

I have setted showMetadata = false in config.toml but it doesn't work.

example

[params]
user = ""
hostname = "renanbastos.dev"
sitedescription = 'Renan Bastos has been working as a Software Engineer for over 9 years with cutting-edge technologies'
showMetadata = false
image
renanbastos93 commented 6 months ago

PR opened: https://github.com/LordMathis/hugo-theme-nightfall/pull/41

LordMathis commented 6 months ago

I see. So basically, if you set it to false it becomes false | true which is evaluates to true

LordMathis commented 6 months ago

Wait actually the disabling works as expected but it has to be changed individually in each post frontmatter. Globally turning off post metadata is not yet implemented. I'd welcome a PR for this. I'll keep this issue open but I'll close #41

renanbastos93 commented 6 months ago

What do you expect to do?

LordMathis commented 6 months ago

The if statement currently checks if .Params.showMetadata is set to false. .Params is set in post frontmatter. To be able to disable post metadata globally it also needs to check .Site.Params.showMetadata. If either of those is false the metadata on that post won't be shown