LordTylus / SE-Torch-Plugin-ALE-Biggest-Grids-Broadcast

https://torchapi.com/plugins/item/b3e6b485-3196-457e-9f12-46a6445ff887
Apache License 2.0
2 stars 1 forks source link

Not count Grids connected to inspected grid by Landing Gear. "BUG" #16

Closed dorimanx closed 3 years ago

dorimanx commented 3 years ago

Hi,

Right now code count grid blocks, by looking at the grid and count all blocks + blocks of other ships connected by landing gear to inspected grid. as game see this grid as 1 grid. but in game we can see that we have 5 fighters on landing gears connected to large ship with 6K blocks. and little fighters add more 3k Blocks, and large ship get marked as TOP grid if setting is set to show grids with 8K blocks.

LordTylus commented 3 years ago

Hi,

this should not be possible. I Only Check for Physical and Mechanical connections based on the plugin settings.

Connections are neither of them so they should always be ignored. Can you provide me with a Blueprint, or a Test world for easier reproduction?

And some screenshots maybe of the grids in question, (especially info tab) and which exact command you running as well as your plugin config?

Thanks :-)

LordTylus commented 3 years ago

Tried Reproducing:

Set Min Blocks to 500 and Used !listbigblockgrids

connection via landing gear does not show the grid the station has 499 blocks and the ship 67

image image

If I disconnect the ship and just add one refinery (the 500th block) image image

it shows up just fine. So its working as intended no bug found.

dorimanx commented 3 years ago

hmm. I see when i add ship on top of other ship with landing gear, my small ship is consumed, and no longer in ships list, but the main ship gaining blocks

dorimanx commented 3 years ago

added 1 ship-landing gear 2-ships 1-ship-Large_and_Small_connected

dorimanx commented 3 years ago

add ship

dorimanx commented 3 years ago

i will do more tests, thank you for your time.

LordTylus commented 3 years ago

Do you use any Mod or Plugin that might "merge" grids like that for stability or performance?

Especially if its big and small ship it sounds like supergridding to me.

In that case it would not be a bug in Gridbroadcast but a side effect of whatever you are using that causes that and I wouldnt be able to fix it.

when I connect my grids I get: image image

which looks as it is supposed to

dorimanx commented 3 years ago

check with dedicate Vrage Remote client. it's shows grid as 1, and supergriding is off. i am doing tests to understand what can that be.

dorimanx commented 3 years ago

Ok, i have done some tests, and i cant make it to mark my ship, with one more ship on landing gear, or connected via connector. not sure what was the issue before, but it's gone. If i will even able to trigger it, i will provide more info. Thanks.