search

LordVeovis / xmlrpc

A port of CookComputing.XmlRpcV2 for dotnet core 2
MIT License
33 stars 21 forks source link

Quantifier {x,y} following nothing #2

Closed freemanke closed 6 years ago

freemanke commented 6 years ago

I think we can not change any exist code if we have not any unit test. we should firstly add unit test to protect exist functions.

wechat screenshot_20180723141245

System.ArgumentException : parsing '^(?:[a-zA-Z0-9]+|*)$' - Quantifier {x,y} following nothing. at System.Text.RegularExpressions.RegexParser.ScanRegex() at System.Text.RegularExpressions.RegexParser.Parse(String re, RegexOptions op) at System.Text.RegularExpressions.Regex..ctor(String pattern, RegexOptions options, TimeSpan matchTimeout, Boolean addToCache) at System.Text.RegularExpressions.Regex..ctor(String pattern) at CookComputing.XmlRpc.XmlRpcSerializer.SelectSingleNode(XmlNode node, String name) at CookComputing.XmlRpc.XmlRpcSerializer.DeserializeResponse(XmlDocument xdoc, Type returnType) at CookComputing.XmlRpc.XmlRpcClientProtocol.Invoke(Object clientObj, MethodInfo mi, Object[] parameters) at XmlRpcProxy69cb78c6-2314-45e2-996b-77ca47f477b7.sayHello()

LordVeovis commented 6 years ago

You are right, I should have tested that but I was too lazy...

I'm currently getting the unit tests from the original project back in the project and this regression was very easy to spot...

LordVeovis commented 6 years ago

v1.0.5 shoud resolve that. I've also added unit tests on the CI to prevent this in the future.