search

LordVeovis / xmlrpc

A port of CookComputing.XmlRpcV2 for dotnet core 2
MIT License
33 stars 21 forks source link

3 issues found by SonarQube #7

Open lorddev opened 5 years ago

lorddev commented 5 years ago

See screenshot

image

LordVeovis commented 5 years ago

I have fixed the lock issue. The GetHashCode however seems good to me even if the XmlRpcDateTime is a class and not a struct, to have a consistent behavior with System.DateTime

lorddev commented 5 years ago

screenclip Non-flags enum marked as [Flags] in XmlRpcNonStandard.

lorddev commented 5 years ago

The flags enum is used for flags, so I don't know why it's reporting this. I would not change it.

epgeroy commented 4 years ago

I set the flag to AllowStringFaultCode and it keeps throwing the error Exception thrown: 'CookComputing.XmlRpc.XmlRpcTypeMismatchException' in Kveer.XmlRPC.dll: 'fault response contains string value where integer expected [fault response : struct mapped to type Fault : member faultCode mapped to type Int32]'