search

LordZoltan / PagerSlidingTabStrip.Net

Port of Java project of the same name by Andreas Stütz (https://github.com/astuetz/PagerSlidingTabStrip) for Xamarin.Android, written in C# .Net.
Apache License 2.0
17 stars 8 forks source link

Rename attributes #3

Closed jamesottaway closed 10 years ago

jamesottaway commented 10 years ago

Fixes #1.

I've tested this change manually by removing the local copy of PagerSlidingTabStrip.Net from my Xamarin app, and instead linking to my fork with the changes below applied.

I'm using the newer Xamarin.Android.Support.v4 library from NuGet rather than the old Mono.Android.Support.v4 library included in the Xamarin.Android toolset, so I updated that too.

I haven't bumped the version number, nor have I changed anything in the Example project.

LordZoltan commented 10 years ago

Hi James,

That's brilliant, thanks. Yes, I'd noticed the Mono.Android.Support.v4 dependency issue too a while back, but because I was developing in tandem for an app - and that had an imminent release - I was kind of a bit lazy there...

But this is perfect - I'll merge, and update the Nuget package as soon as I can, and put together a little guide on the readme for people to see how to fix problems after the upgrade.

jamesottaway commented 10 years ago

Awesome, thanks for the feedback.