search

Lordhacker756 / open-dashboard

A Minimalistic dashboard app/ chrome extension for everyone built for the open source community💜. Feel free to fork the repository and customize the app as you like
https://open-dashboard.vercel.app/
9 stars 8 forks source link

Feature/download link for background #16

Closed lukxxx closed 2 years ago

lukxxx commented 2 years ago

Related issue

https://github.com/Lordhacker756/open-dashboard/issues/13

 Changes

Fixed bug where background image was fetching with every interaction with app

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
open-dashboard ✅ Ready (Inspect) Visit Preview Jun 27, 2022 at 10:01PM (UTC)
lukxxx commented 2 years ago

@Lordhacker756 I dont know why are there conflicts but you know how to resolve them. :D

lukxxx commented 2 years ago

@Lordhacker756 Is this okay or is there something wrong?

Lordhacker756 commented 2 years ago

Hey there @lukxxx , I tried to resolve the change and I saw another bug🐛. The fallback image is not loading when the network is not there and rather it's showing us a blank background. I've created a separate beta branch where we can test these problems

image

Please look into this bug and open a new pull request in the beta branch 😄

lukxxx commented 2 years ago

@Lordhacker756 okay thanks for the info I will look into this :D Thanks. Should be this pull request closed then or not?

Lordhacker756 commented 2 years ago

I'm closing this pull request😄