search

Loreinator / Shuffle-Move

Program to help choose moves in the Pokemon Shuffle puzzle game
GNU General Public License v3.0
95 stars 18 forks source link

Invalid team data stops the editor from loading #14

Closed Loreinator closed 9 years ago

Loreinator commented 9 years ago

When the team data stores an invalid species name it will fail to load the Team Editor to even attempt to correct this.

Correct behavior would be that when the species of a team is being obtained, all dependent processes should be fine to handle the absence of a species.

Additionally, perhaps the whole name and number system should be redesigned slightly - have a lookup config manager that maintains a name-based lookup for the number, and upon loading allow a simple lookup to identify the species name from a number. There should obviously be a 'default' flag for which is dominant and displayed in the client, and this could tie into the other issue about species name localization. Shouldn't take too long, maybe a few evenings or so (no rush since there are workarounds available).

Loreinator commented 9 years ago

Fixed with some basic team data checking by cross referencing with the species manager on load. This also includes some basic handling so that IF there were to be some way for the team data to still be invalid after these checks, an 'Air' block would be allowed through in the team editor as a species.