I noticed that some of the mechanics of how the status effects count needs improvement. I propose the following change:
Take "Sleep Charm" as an example. When it activates, the effects last for 2.5 turns. That means for TWO full turns worth of play, the opponent will stay asleep; take x1.2 damage; "Sleep Combo" will add x1.5 damage to all damage done; and the opponent cannot be given any other status effects.
Mega Abilities like Tyranitar and Beedrill will delay this countdown for 1 turn, as long as they are the first move you initiate; similarly for making a match that trigger Mega Evolution; "Mind Zap" also delays the countdown, and can be triggered in tandem with status effects.
When the two turns are over the sleep animation is still active, meaning that you cannot inflict a new status effect; it also means "Sleep Combo" can activate. However, as soon as you make your first move, the opponent will wake up; this means "Sleep Combo" will only boost the attack of the first match. This is the HALF TURN I was talking about.
Effects like Quake/Chill/Astonish/Whirlpool/Flap/etc. all trigger Paralysis, but only for a HALF TURN. I don't know about the other abilities, but I know "Quake" is currently coded incorrectly, for 2 full turns, just like "Paralyze". Effects like Burn, Freeze, etc. have the same issue as Sleep Charm.
I suggest that you change the countdown timer to say "0" when there is only a HALF TURN left. This would make ShuffleMove take into consideration things like (1) not being able to inflict a new status effect (2) having only the first move in the match get an extra boost.
In my experience, I've seen ShuffleMove suggest a "Sleep Combo" move when there is only a half turn left, even though it would have been more beneficial to make another match first, just because it thinks all the moves will be boosted in the combo, rather than only the first. I've also seen it suggest making a "Sleep Charm" match because it thinks the opponent has already woken up, even though there is still a half turn left. These kinds of things would be nice to have straightened out.
From /u/WhatNot303 on reddit here:
I noticed that some of the mechanics of how the status effects count needs improvement. I propose the following change:
Effects like Quake/Chill/Astonish/Whirlpool/Flap/etc. all trigger Paralysis, but only for a HALF TURN. I don't know about the other abilities, but I know "Quake" is currently coded incorrectly, for 2 full turns, just like "Paralyze". Effects like Burn, Freeze, etc. have the same issue as Sleep Charm.
I suggest that you change the countdown timer to say "0" when there is only a HALF TURN left. This would make ShuffleMove take into consideration things like (1) not being able to inflict a new status effect (2) having only the first move in the match get an extra boost.
In my experience, I've seen ShuffleMove suggest a "Sleep Combo" move when there is only a half turn left, even though it would have been more beneficial to make another match first, just because it thinks all the moves will be boosted in the combo, rather than only the first. I've also seen it suggest making a "Sleep Charm" match because it thinks the opponent has already woken up, even though there is still a half turn left. These kinds of things would be nice to have straightened out.