search

Loreinator / Shuffle-Move

Program to help choose moves in the Pokemon Shuffle puzzle game
GNU General Public License v3.0
95 stars 18 forks source link

Flash mob damage isn't calculated properly #297

Closed ZeroRin closed 7 years ago

ZeroRin commented 7 years ago

flash mob deals damage according to the number of one type of pokemon on board but the program seems to only calculated the pokemon that triggered the skill. just same as crowd control

ZeroRin commented 7 years ago

1fhiunmcli g1np7lossm1g

ze2 3m_ 2l 8 x935g1vv

testing picture, the damage should be around 1000

Manitary commented 7 years ago

Can confirm, tried with Keldeo and other water types.

I don't know much how to interpret all the functions, but at a glance the problem could be related to these line in Effects.java:

Species effectSpecies = task.getEffectSpecies(comboEffect.getCoords()); int num = task.findMatches(36, true,(r, c, s) -> (s.equals(effectSpecies) [...]

If getEffectSpecies looks for the icons of the same species on the board, that's where the problem is.

Loreinator commented 7 years ago

Found the issue and fixed it in the master branch, it'll be part of the next release

It was just a difference between checking for species that equal the effect species, versus checking for species that match the effect species' type.

Oh, btw this line: Species effectSpecies = task.getEffectSpecies(comboEffect.getCoords()); Is just the way that the task allows the effect to look up what species is on the coordinate of the match.