Closed GoogleCodeExporter closed 9 years ago
Original comment by lorelle...@gmail.com
on 31 Dec 2013 at 5:49
[deleted comment]
This article is on your student site. According to the guidelines, it must not
be published on your student site but submitted as pending on ClarkWP. Please
let me know if you are having trouble signing into ClarkWP. Thanks.
Original comment by lorelle...@gmail.com
on 27 Jan 2014 at 4:19
According to my dashboard it is pending. See attachment.
Original comment by nick3...@gmail.com
on 28 Jan 2014 at 2:13
Attachments:
http://nelictec.wordpress.com/?p=113&preview=true&preview_id=113&preview_nonce=0
ad2dd2661&post_format=standard
Original comment by nick3...@gmail.com
on 28 Jan 2014 at 2:18
Again, the article is on your student site, not on ClarkWP. Please put it on
ClarkWP and delete the article from your student site per the instructions for
publishing on ClarkWP.
We cannot view any posts pending and not published on your student site as we
don't have access to your login nor are able to log into your site. All posts
published per the assignments for ClarkWP must be on ClarkWP. We can view
previews there as we are members of the site and able to log in.
Thanks.
Original comment by lorelle...@gmail.com
on 28 Jan 2014 at 3:04
http://clarkwp.wordpress.com/?p=2615&preview=true&preview_id=2615&preview_nonce=
dfa0857e79&post_format=standard
Original comment by nick3...@gmail.com
on 28 Jan 2014 at 8:32
I changed the post itself from Published to Pending since none of us editors
had a chance to look at it prior to it being published. I've checked it for
grammar/punctuation/spelling and made some minor changes. My only suggestion is
that you need to go in and set your Categories and Tags.
Lorelle, I think you are probably the best to check this for content as,
content-wise, I got lost rather quickly and am not sure if there are any
content related edits that should be made.
Oh, PS, in the future, Nick, you need to make sure you change the Owner (below)
to you on the article that you're working on so that we know who's working on
it. I've gone ahead and changed it here for you already.
Karen
Original comment by kldesem...@gmail.com
on 29 Jan 2014 at 2:40
Lorrelle, can we use images with citation if there is no policy on the persons
cite? I know the rule of thumb is 10% or 400 words but how does this apply to
to imgs? Could you take a look at the content it seems to be a little over my
head. If it is good, would you publish it?
Original comment by jojogrlw...@gmail.com
on 29 Jan 2014 at 2:16
Nick, can you change the citation link to the person's site, not the image. It
is critical that we link to the person as part of giving credit. Thanks!
If there is no policy on their person's site, it's a hit or miss process. If
the usage is within Copyright Fair Use, and it includes a link to the web page
featuring the content, or to the front page of the site representing the
copyright holder, then it is okay. If they come to complain, we must respond
appropriately.
My personal and professional rule is to never use an image or content that
violates Copyright Fair Use. I don't use photographs or graphics that don't
have a copyright policy that allows me to do so as those are complete entities
and I cannot really use 10% of an image to make it work. I just make it my
policy to not assume for a copyright holder.
From there, it is up to the editors to decide. It is a fine line.
Nick: About the article.
Great start. Well thought out and some brilliant information in there. Some
details, though.
You define HTML and CSS beautifully. Start a new paragraph with the statement
about media queries as that is a concept in and of itself.
Please use http://en.support.wordpress.com/code/posting-source-code/ for
publishing code on the site.
A tutorial like this starts out with introductory paragraphs, which you've done
beautifully, then needs to be broken up into sections grouping related points
together under headings. This process does two things.
First, it slows down the consumption of the information into digestible chunks
for the reader new to the concept.
Second, and in reverse, it speeds up the consumption of the information to
those familiar with the subject because they can jump to the part of the
process they need to review for their work, and to get their questions
answered.
A tutorial like this, one that introduces new concepts to readers, is a
journey. Present it like one, which you've done for the most part. This is what
I'm talking about, this is an example, here is how to do it, here are some
other ways to do it, now tie it all up with a nice bow to tell you what I told
you and assure you, kind reader, that you can do it.
In the paragraph about creating the media stylesheet, you introduce the concept
of themes. Before this, you haven't addressed whether you are going to talk
about stylesheets for WordPress Themes or any CMS, as you were a bit vague in
the beginning of the article. If this is going to be a specific WordPress Theme
article, which is appropriate to the purpose of ClarkWP, the topic needs to use
the right naming conventions for WordPress Theme elements and files, and
clarify that you are talking about WordPress Theme development and design.
There are specific standardized places to put the media stylesheet in a
WordPress Theme. It is always in the WordPress Theme folder under
wp-content/themes/ and it is usually in the root of the WordPress Theme folder,
or in a collection of stylesheets in a folder under the Theme folder called css
or media.
The WordPress Theme stylesheet is required to be named style.css. While you are
right that the media stylesheet maybe named anything, clarify it must be named
appropriately and not after their favorite pet or child. style-media.css or
media-styles.css or just media.css are typical name examples. WordPress
guidelines for code semantics and practices state that file names should be
specific to their purpose and instantly recognizable.
There are two ways of "attaching" a stylesheet in WordPress Themes. Yes, one is
through the header.php file (not other WordPress Template Files). The other is
by embedding the stylesheet through an import in the core style.css file.
Describing the stylsheet embed in the header.php file of a WordPress Theme, you
must use the WordPress template files that locate the Theme being used in the
filename. Information is in the WordPress Codex, and links to such guides and
tutorials are needed in the article.
At the end, you make some good points, but you reference the wrong WordPress
template file. Page.php is ONLY used for the generation of WordPress Pages, not
posts. That meta tag would be added to the header.php for the Theme so all
pageviews would be treated equally in the mobile browser.
There are no reference articles or discussion about WordPress Themes
You mention in the article that adding such CSS for media would be a messy long
addition to the style.css/stylesheet. So far, you've shown us only a few lines
of code, so that doesn't look like much. You might want to follow through on
this by explaining that changing the viewing size doesn't mean your site is
suddenly mobile-friendly. Much more goes into it such as navigation elements
and their flexibility to adjust, font sizes, images, and other layout issues.
You don't have to write a book on the subject, but this is a hole in the
article that needs filling.
Responsive and Adaptive web design is not just about mobile. It's about
everything. This is for print, web-tv, and other ways people access the web.
Media stylesheets have been around as a standard in web design since before
1999. Just because people don't use them doesn't mean they are new. It is
critical that people understand how to build responsible web designs, without a
doubt, and you've done a great intro and description of how to do that quickly
and easily. Just fill in the little holes and make sure it is WordPress-centric
or not. The request was an article on how to make a WordPress Theme
mobile-friendly, so let's try to keep it WordPress Theme specific.
Per the request in the article instructions at the top, could you please
suggest the other two articles to other students on ClarkWP SVN. The
instructions for how to suggest an article are on the front page of the site
and the Wiki. Thanks!
And thanks! I've been eager for this, and it asks much of your coding
expertise, so I expect more, too. :D You can do it. I know you can! Thanks so
much.
Original comment by lorelle...@gmail.com
on 29 Jan 2014 at 7:18
Thanks for moving the article to ClarkWP from your student site.
I went through this per the editor's request and lack of familiarity with the
subject. Here are my notes.
The core of this is fabulous, a great start, but it is missing information that
rounds the article and subject matter out a little.
The usage of the code or sourcecode shortcode really helps the article present
the code much better. Thank you.
I found links without title attributes in the HTML tag. I corrected some but
please go through the links and ensure they have the titles.
Incorporate "example" into the sentences leading up to the example. It looks
odd just sitting there not capitalized and in italics. It isn't a professional
presentation style. I removed them, and the article works and flows better.
The standard default for all WordPress Theme stylesheets is style.css, so
randomly naming the media stylesheet style.css is not a good recommendation.
I've talked about this in the above comments. It should be called what it is,
per web and WordPress standards and code practices, such as media.css.
Please correct the article per the notes above.
Punctuation at the end of a sentence with quote marks goes inside of the quote,
not out.
This made me giggle: templages. It is templates. Fixed.
Code posted within a paragraph uses the <code> HTML tag for emphasis as code.
This is the instruction for creating the stylesheet link in a WordPress Theme
http://codex.wordpress.org/Function_Reference/get_stylesheet_directory Please
correct the article accordingly and link to that reference.
"Alternatively, if you do not want your web page to respond to web browser
sizes, do not have this technical ability, or just do not feel like putting in
the work, you could just add this in your <code>page.php</code> file."
I can guess what you mean, but this doesn't make sense. As stated in the
comments above, page.php displays WordPress Pages, not posts, categories,
archives, etc., pageviews. Addition of this meta tag would be inappropriate on
the page.php in a WordPress Theme as the header would be called anyway. All
such meta tags should be in the header.php file, and this is an alternative to
the stylesheet.
Again, the article feels incomplete. You do not mention the important aspect of
controlling images, especially header art, and some navigation elements for
Mobile Themes. It's more than just the width of the content.
You describe "container" as a CSS container class but do not talk about which
container should have the width set. The entire HTML, a wrapper, the content,
what about the sidebar, etc.
Remember your audience. You are writing this for the students in this class and
future classes. This is a great article to include in the class notes, but it
takes the standard up for the article to offer a fairly complete tutorial.
Otherwise, we need to change the post title so it doesn't create expectations
that this is an article covering the entire topic exhaustively.
I'm going to put this back to draft to help the editors keep track of what they
should be paying attention to.
Really good start, just needs polishing. I'll not grade you for it being late
due to the misunderstanding of publishing it on your student site, but I'd like
to finish this up soon. Thanks!
Original comment by lorelle...@gmail.com
on 2 Feb 2014 at 9:28
I added tags for you, but please change your display name to be something that
isn't your username. Thanks.
Original comment by lorelle...@gmail.com
on 2 Feb 2014 at 9:29
Thanks for making changes. The article is just the tip of the ice berg for the
topic, but changing the post title to "Tips" makes it work.
I've added related posts per request and published the article. Thanks for
taking the extra time on this to get it right.
Original comment by lorelle...@gmail.com
on 7 Feb 2014 at 7:52
Original comment by lorelle...@gmail.com
on 7 Mar 2014 at 11:49
Original issue reported on code.google.com by
lorelle...@gmail.com
on 19 Dec 2013 at 1:06