LoremVIpsum / OpenSimpleFrames

Carpenters Blocks but using states?
https://modrinth.com/mod/open-simple-frames
MIT License
9 stars 5 forks source link

[Bug] 1.20.1 (fabric) frames dont have all faces rendered and are invis. #26

Open JSmids opened 11 months ago

JSmids commented 11 months ago

Hello! I have been using this mod for a bit now in a mod pack with create i had made currently using fabric 14.23. It was working flawlessly till now when it will no longer render certain faces of the block. the only thing that stands out to maybe effect it was switching my shaders off and disabling a "fps mod". but now i can not get them to render no matter if i disable shaders or restart pc/MC or if i repair my MC install. Thanks for any help!

Pictured corner frame, inset, stairs, ramp, door, h fence, might be another i missed that doesn't render fully. image

LoremVIpsum commented 11 months ago

I imagine the problem here is to do with the way the frames cache textures, if you try applying an item texture with left or right click, does that then make it work, or does it simply refuse to apply textures now?

LoremVIpsum commented 11 months ago

(sorry for the late reply, i have been really busy)

GeekyBakerBen commented 11 months ago

I literally just tried this mod for the first time today (on Fabric 1.20.1) and have the exact same experience. Both fences, and the ramp blocks don't render correctly, with invisible/missing sections (fences are just the posts, the ramps are invisible on sides and back). Also had issue (presumably same problem) with chest not showing any frame faces and just looking like a normal chest, and wouldn't apply texture to the chest or the 2x2 block, rest accepted textures ok. Could be multiple mixed problems there, but all felt like this same issue that JSmids is having.

JSmids commented 11 months ago

I can add textures and when I add a new texture it just applies it to what is rendered even if I swap the textures a few times, tho I will say the first time I reapplied a textures just now it did take a few seconds for it to register that it was now different but then it went back to swapping at normal speed. Also all good for late reply I had taken a break from MC anyway.

(these are the 3 side inset blocks) image

BigClarky commented 10 months ago

same thing happens on 1.19.2

LoremVIpsum commented 10 months ago

I have not yet been able to do anything about this as I basically havent been modding and am full time now - I do recall when using sodium the way some of the blocks are rendered differently, when I was testing Im fairly sure I always had sodium installed, but they could have changed things or fabric could have changed things (as some of the other issues here seem to be regarding the mod loader itself) i dont know when ill get time to fix these things or look at them, but hopefully someone will be able to help

LoremVIpsum commented 9 months ago

So I really don't know why this happens but I thinks it's related to a bunch of other issues here, the closest I can get is placing a two-cover in a world then adding sodium, but even then, interacting with it corrected the directions and rendering

LoremVIpsum commented 9 months ago

Have a look at the new version I released see if you have similar problems, and if you do could you try and recreate them in a world you can send to me?

dhasial commented 7 months ago

I created a new superflat world in 1.19.2 Fabric and created a demo world for this bug. I didn't install Sodium to see if the bug was the same as with it, and it seemed to be the same. I also used signs to give notes on two other bugs I noticed while making it.

Those bugs are that sometimes a block is placed in addition to the texture being applied (#36), and on two frames (door and chest) the texture can't be applied at all because of the animation (#9, first bullet point) .

OpenSimpleFrames bug demo world.zip

edit: This was all done on the latest release

also, here's a screenshot of the ramps not displaying the texture correctly (first, main bug)