search

LoremVIpsum / OpenSimpleFrames

Carpenters Blocks but using states?
https://modrinth.com/mod/open-simple-frames
MIT License
9 stars 5 forks source link

Updating to 1.21 #40

Open Pokerfaceuhd opened 3 months ago

Pokerfaceuhd commented 3 months ago

I have been working on porting this mod to 1.21, there is only one issue left.

In BakedQuadFactoryMixin it needs to filter out some stuff with modelId.getPath().equals(base) in the capture method but modelId (which is of type Identifier) no longer gets input into the bake method in BakedQuadFactory. Ive tried using the ModelBakeSettings and casting those to ModelVariants which have the Path but that doesnt seem to work lead to the same results.

Without it all the models try to render on top of each other for every simple frames block.

I would appreciate some help with this.

LoremVIpsum commented 3 months ago

So as you can probably see I haven't logged into this account for a while because of life and such, but thank you for attempting to port the mod! at some point I really want to rewrite a bunch of the internals to fix a bunch of the errors but I haven't had time yet - there is the potentially that the method you are using or think your using is now called something else entirely if you look through that class, and then it might have the identifier as inputs, otherwise its probably codecs and records which i do not know so much about