search

LorenFrankLab / rec_to_nwb

Data Migration REC -> NWB 2.0 Service
Other
2 stars 8 forks source link

Address best practices violations #41

Closed rly closed 1 year ago

rly commented 1 year ago

These best practices violations came up when Abhilasha tried to upload her data to DANDI. These should be addressed in the generation of the NWB file. I'm not sure if this is the right repo to report this or if these have been addressed already.

See here for a full list of best practices https://nwbinspector.readthedocs.io/en/dev/best_practices/best_practices_index.html (most of these were written after rec_to_nwb was written).

Required for DANDI upload:

  1. The subject sex should be "M", "F", "U" (unknown), or "O" (other)
  2. The subject age or data of birth is required. For formatting, see the above documentation
  3. The file path to the external video file should be a relative path not an absolute path

Highly recommended:

  1. The ProcessingModule "camera_sample_frame_counts" should not be added. Its timestamps are non-ascending, and its values are difficult to interpret and apparently superfluous for time alignment of cameras with other data (please confirm @khl02007)
  2. The subject species name should be the latin binomial name, e.g., "Rattus norvegicus" not "rat"
  3. The experimenter name should have one of these forms: 'LastName, Firstname', 'LastName, FirstName MiddleInitial.' or 'LastName, FirstName, MiddleName'