LorenFrankLab / spyglass

Neuroscience data analysis framework for reproducible research built by Loren Frank Lab at UCSF

https://lorenfranklab.github.io/spyglass/

MIT License

94 stars 43 forks source link

Fix 1080 #1099

Closed CBroz1 closed 2 months ago

CBroz1 commented 2 months ago

Description

1053 made an edit to `_compute_metric` control flow anticipating an early return, but instead allowed `isi_violation` to be recomputed for each unit. This is present in the most recent release, but will result in failed saving, as shown in #1080, because the embedded dictionary will not be able to save to json

Checklist:

[x] No. This PR should be accompanied by a release: (yes/no/unsure)
[x] N/a. If release, I have updated the CITATION.cff
[x] No. This PR makes edits to table definitions: (yes/no)
[x] N/a. If table edits, I have included an alter snippet for release notes.
[x] No. If this PR makes changes to position, I ran the relevant tests locally.
[x] I have updated the CHANGELOG.md with PR number and description.
[x] N/a. I have added/edited docs/notebooks to reflect the changes