LorenFrankLab / spyglass

Neuroscience data analysis framework for reproducible research built by Loren Frank Lab at UCSF
https://lorenfranklab.github.io/spyglass/
MIT License
93 stars 42 forks source link

Install documentation uses kachery-client instead of kachery-cloud #342

Closed rsnevers closed 1 year ago

rsnevers commented 2 years ago

I'm helping to set up spyglass on a new machine and following the install instructions at https://lorenfranklab.github.io/spyglass/type/html/installation.html

On step 3 under "Setting up database access", there is a command that calls kachery-client to check for access to the kachery daemon. Apparently, we are now using kachery-cloud instead of kachery-client so the documentation should be changed to reflect this.

edeno commented 2 years ago

@zoldello can you update the documentation?

zoldello commented 2 years ago

@rsnevers Please, verify this was fixed. If not, reopen this ticket.

khl02007 commented 2 years ago

@zoldello simply changing kachery-client to kachery-cloud doesn't work - the whole section must be changed. I thought I had changed it and pushed it to documentation branch yesterday but it seems it has been changed back and I don't see it in the commit history. Do you know what happened?

zoldello commented 2 years ago

@khl02007 I will look into this. I made a mistake where I changed the type tokachary-client from kachery-cloud and I undid that with a commit. I did not remove the entire commit because I had other things that were part of it (bad practice for commits to not be atomic.) Otherwise, the text was not change from what you did. Maybe it got affected when I rebased the code off masterto update the notebooks with Eric's and Daniel's work.

khl02007 commented 2 years ago

@zoldello I just pushed the updated installation.md to my fork (khl02007/documentation). do you think you can get it from there?

zoldello commented 2 years ago

@khl02007 I will get it off there and update you.