The latest sortingview 0.11.15 removes some old functionalities that are still referenced in our Spyglass code, causing a basic import error. Essentially, sortingview workspaces are no longer used. I can handle the PR but want to check what folks are ready to delete or not first, so just starting with an issue for now.
the first one (_add_metrics_to_sorting_in_workspace) doesn't have any references in Spyglass, so unless folks are using it elsewhere in notebooks etc, I think we can go ahead and remove. Lmk if anyone disagrees.
edeno
commented
1 year ago
The latest sortingview 0.11.15 removes some old functionalities that are still referenced in our Spyglass code, causing a basic import error. Essentially, sortingview workspaces are no longer used. I can handle the PR but want to check what folks are ready to delete or not first, so just starting with an issue for now.
The two places where sv.Workspace gets called right now are in the first two functions here: https://github.com/LorenFrankLab/spyglass/blob/7ee84c4948f121c0c75c7a535d866e3f1129a9a1/src/spyglass/spikesorting/sortingview_helper_fn.py
_add_metrics_to_sorting_in_workspace) doesn't have any references in Spyglass, so unless folks are using it elsewhere in notebooks etc, I think we can go ahead and remove. Lmk if anyone disagrees._create_spikesortingview_workspace) is just referenced here - in the SortingviewWorkspace schema - https://github.com/LorenFrankLab/spyglass/blob/7ee84c4948f121c0c75c7a535d866e3f1129a9a1/src/spyglass/spikesorting/sortingview.py#L7:~:text=do,%3D%20_create_spikesortingview_workspace( Can anyone speak to whether theseSortingviewWorkspaceschema are fully deprecated? And if we'd be ready to remove these if they are no longer supported? @khl02007 , @MichaelCoulter perhaps you'd have thoughts on this.(FYI from Jeremy: "kachery/figurl no longer supports feeds, and so those functions wouldn't work anyway")
Thanks in advance for any input