LorenFrankLab / trodes_to_nwb

Converts data from SpikeGadgets to the NWB Data Format
MIT License
2 stars 2 forks source link

Run nwbinspector on conversion output, generate report #60

Closed rly closed 6 months ago

rly commented 7 months ago

Fix #37

NWB Inspector now runs on the output NWB file and generates a report at {base}_nwbinspector_report.txt where {base} is the output NWB file path without .nwb.

If NWB Inspector finds any critical errors that would block DANDI upload, the full inspector summary is printed to stdout. Otherwise, a count of the best practice violations and suggestions is printed to stdout. The path to the report file is also printed to stdout.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (46fa4f1) 90.10% compared to head (25e0dc7) 90.63%. Report is 5 commits behind head on main.

:exclamation: Current head 25e0dc7 differs from pull request most recent head 330137f. Consider uploading reports for the commit 330137f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #60 +/- ## ========================================== + Coverage 90.10% 90.63% +0.52% ========================================== Files 25 25 Lines 2275 2318 +43 ========================================== + Hits 2050 2101 +51 + Misses 225 217 -8 ``` | [Files](https://app.codecov.io/gh/LorenFrankLab/spikegadgets_to_nwb/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LorenFrankLab) | Coverage Δ | | |---|---|---| | [src/spikegadgets\_to\_nwb/convert.py](https://app.codecov.io/gh/LorenFrankLab/spikegadgets_to_nwb/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LorenFrankLab#diff-c3JjL3NwaWtlZ2FkZ2V0c190b19ud2IvY29udmVydC5weQ==) | `83.09% <100.00%> (+10.44%)` | :arrow_up: | | [src/spikegadgets\_to\_nwb/tests/test\_convert.py](https://app.codecov.io/gh/LorenFrankLab/spikegadgets_to_nwb/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LorenFrankLab#diff-c3JjL3NwaWtlZ2FkZ2V0c190b19ud2IvdGVzdHMvdGVzdF9jb252ZXJ0LnB5) | `99.19% <100.00%> (+0.13%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.