LorenFrankLab / trodes_to_nwb

Converts data from SpikeGadgets to the NWB Data Format
MIT License
2 stars 2 forks source link

Handle cases where uint32 wrapping prevents use of digitize #61

Closed samuelbray32 closed 7 months ago

samuelbray32 commented 7 months ago

Addresses #59 by leaving the sample trodes_timestamps as-is, but fixing index lookup of sample count in non-ptp cases of add_position

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (46fa4f1) 90.10% compared to head (c6f7aef) 90.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #61 +/- ## ========================================== + Coverage 90.10% 90.21% +0.10% ========================================== Files 25 25 Lines 2275 2300 +25 ========================================== + Hits 2050 2075 +25 Misses 225 225 ``` | [Files](https://app.codecov.io/gh/LorenFrankLab/spikegadgets_to_nwb/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LorenFrankLab) | Coverage Δ | | |---|---|---| | [src/spikegadgets\_to\_nwb/convert\_position.py](https://app.codecov.io/gh/LorenFrankLab/spikegadgets_to_nwb/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LorenFrankLab#diff-c3JjL3NwaWtlZ2FkZ2V0c190b19ud2IvY29udmVydF9wb3NpdGlvbi5weQ==) | `87.54% <100.00%> (+0.92%)` | :arrow_up: | | [...spikegadgets\_to\_nwb/tests/test\_convert\_position.py](https://app.codecov.io/gh/LorenFrankLab/spikegadgets_to_nwb/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LorenFrankLab#diff-c3JjL3NwaWtlZ2FkZ2V0c190b19ud2IvdGVzdHMvdGVzdF9jb252ZXJ0X3Bvc2l0aW9uLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.