search

Lorentz83 / userscripts

My Greasemonkey userscripts
8 stars 0 forks source link

Imitate native style for title text box. #3

Closed Ede123 closed 8 years ago

Ede123 commented 8 years ago

Here's a suggestion for an updated style of the title text box.

It's using xkcd's native ".box" style class and I think it blends in really nice.

Lorentz83 commented 8 years ago

It is nice, but doesn't work well on what-if. I want to fix the style also for what-if before merging your suggestion. Thank you

Ede123 commented 8 years ago

Thanks, I completely forgot about What-If! If you approve of the principle design I can have a look at it myself and update my pull request.

If you want to do the adjustments yourself that's fine with me, too, of course ;-)

Am 2. Oktober 2015 4:23:21 nachm. schrieb Lorenzo Bossi notifications@github.com:

It is nice, but doesn't work well on what-if. I want to fix the style also for what-if before merging your suggestion. Thank you

Reply to this email directly or view it on GitHub: https://github.com/Lorentz83/userscripts/pull/3#issuecomment-145035996

Lorentz83 commented 8 years ago

Right now I've integrated your pull request. But I've added also some extra stuff to make it easier managing the two different websites. In detail, instead of embedding the css into the html tag, I have created three extra classes, one for the common style one and one for each website.

Right now I've left the old style to what-if, because its graphics is so different compared to xkcd that using the same style looks very ugly. Of course your help is welcome.

Since this change, I wonder if we can integrate better the "explain this" link using the same style of the navbar. But I cannot decide if it looks better inside the navbar (between random and next) or above where it is now.

Thanks again :)