search

Loriowar / redmine_issues_tree

Provides a tree view of the Redmine issues list
GNU General Public License v3.0
115 stars 72 forks source link

adding source host to Gemfile #81

Closed Szuuuken closed 6 years ago

Szuuuken commented 6 years ago

Added "source 'https://rubygems.org'" to Gemfile. This streamlines the installation process with "bundle".

Tab10id commented 6 years ago

Why you need this? Gemfiles of plugins evaled in main Gemfile by this: https://github.com/redmine/redmine/blob/c422bee4c4087711c3893f1ef2f62e5f7022565e/Gemfile#L102-L105 and it already contain source defenition.

Szuuuken commented 6 years ago

Because without this line bundle was giving me the following error: Your Gemfile has no gem server sources. If you need gems that are not already on your machine, add a line like this to your Gemfile: source 'https://rubygems.org'

steps to reproduce:

$ cd /var/www/redmine/plugins/
$ git clone -b 3.4.x https://github.com/Loriowar/redmine_issues_tree.git
$ cd redmine_issues_tree
$ bundle
Your Gemfile has no gem server sources. If you need gems that are not already on your machine, add a line like this to your Gemfile:
source 'https://rubygems.org'
Could not find gem 'haml-rails' in any of the gem sources listed in your Gemfile.

After adding the source host everything worked just fine.

Loriowar commented 6 years ago

There is no needs to run a bundle command from a cloned plugin directory. A standalone plugin is useless. In any case, the plugin is part of a Redmine installation. So you do strange things and this pull-request doesn't really needed for any real purpose.