search

Loriowar / redmine_issues_tree

Provides a tree view of the Redmine issues list
GNU General Public License v3.0
115 stars 72 forks source link

Some crude fixes for Redmine 4.0.0 with Rails 5 and Ruby 2.4 #86

Closed haraldkl closed 5 years ago

haraldkl commented 5 years ago

After updating the system, the plugin stopped to work due to changes in Ruby and Rails. In Rails 5 parameters need to be filtered. I now simply allow all, though that is likely not the best thing to do? But it works for me. And the other problem is that alias_method_chain is not supported anymore by recent Ruby versions. I replaced these now with alias_method, though a more appropriate approach may be to make use of the module prepend facility.

I have no idea, whether these changes are advisable, but I got the plugin running in Redmine 4.0 with this.

Loriowar commented 5 years ago

@haraldkl, thanks for help. Here is a complex patch for support Redmine 4.0.x: 7c10197c761ac722baf85c902eafa2379126893b. Moreover, now available branch 4.0.x. Please, switch to it if you use Redmine 4.0.0.

haraldkl commented 5 years ago

Great! Thanks a lot!