search

Lorti / dominant-colors-lazy-loading-wordpress-plugin

This plugin allows you to lazy load your images while showing the dominant color of each image as a placeholder – like Pinterest or Google Images.
https://wordpress.org/plugins/dominant-colors-lazy-loading/
GNU General Public License v2.0
95 stars 10 forks source link

Not all media file types should be used by the plugin #7

Closed pedro-mendonca closed 8 years ago

pedro-mendonca commented 8 years ago

Hi,

I'm testing the plugin in a library with different types of files, at least I have JPG and PDF.

The PDF isn't parsed by the plugin, and this expected. The problem is that the PDF is listed as a parsable file and listed in the error list after the Calculate I believe this could be corrected by filtering out PDFs, or the oposite, giving a finite list of the file types that can be calculated by the plugin. In this case, probably the file type list should be documented in the settings page, and probably also the file list to process should include the files extensions.

Lorti commented 8 years ago

You are right, the recalculation in the settings page needs rethinking and some work. This is tied to #5.

pedro-mendonca commented 8 years ago

This not a malfunction, is just a false positive error, that needs some polishement :+1:

Lorti commented 8 years ago

Thank you for both the hint and the pull request, only image mime types are now supported.

pedro-mendonca commented 8 years ago

Hi @Lorti One more thing, if you want I can open a new issue. When there are some files that can't be calculated, they don't appear listed, which makes it more dificult to find what files need to be checked manually.

Lorti commented 8 years ago

I figured that the fallback can handle those files, as one can not fix what Imagick can't process. You would have to reupload them differently. But yes, open an issue (enhancement) if you want. Should only need a few small changes :-)

pedro-mendonca commented 8 years ago

Ok. I do find it usefull because I found a case where it can serve as debug. If a file isn't found, than something can be fixed somewhere, and it's a good idea to know wwich files rather than just a permanent number of resistent files not calculable. Thanks, I'll open an issue with this than.