search

Loschcode / vue-mixpanel

A simple Vue.js plugin for Mixpanel
https://laurent.tech
MIT License
38 stars 4 forks source link

fix: set the configuration within the init call right away #4

Closed DeepDiver1975 closed 3 years ago

DeepDiver1975 commented 3 years ago

the init function can take token and config object the same time.

Especially in the case when an api_host is specified there are still requests to be observed which go to the default host.

see https://developer.mixpanel.com/docs/javascript-full-api-reference#mixpanelinit

DeepDiver1975 commented 3 years ago

@Loschcode hey - any chance to get this reviewed? Please let me know if there is anything to unblock this.

THX and have a great weekend!

Loschcode commented 3 years ago

@Loschcode hey - any chance to get this reviewed? Please let me know if there is anything to unblock this.

THX and have a great weekend!

Sorry for the late reply, I hadn't seen your PR. I'll check it.

DeepDiver1975 commented 3 years ago

No worries. Thanks for merging!