Request/quesion: Update to VS2019 - Githubissues

LostAlloy / LocalHistory-for-Visual-Studio

Local History for Visual Studio automatically creates a history of your files every time they are saved. The history can be compared with the current version.

https://marketplace.visualstudio.com/items?itemName=lostalloy.LocalHistory-for-Visual-Studio

17 stars 5 forks source link

Request/quesion: Update to VS2019 #7

Open stevenwdv opened 5 years ago

stevenwdv commented 5 years ago

Will this be updated to support VS 2019, which is now in preview?

I think the tool is really useful, so I hope you will find the time to do this! :)

SugoiDev commented 5 years ago

I plan on keeping it working, yes!

Did you test with 2019?

stevenwdv commented 5 years ago

Nice! I tried to install it but it said it was already installed in all supported versions. It's also not visible in the online extensions panel within VS.

SugoiDev commented 5 years ago

Oh, thanks for the info!

I'll test it locally and see if it works already. If it does, I'll push a new version to the marketplace.

SugoiDev commented 5 years ago

@stevenwdv I just pushed a beta with preliminary support for VS 2019. It's not on the Marketplace yet, but you can test it by downloading from the releases page.

Let me know if it works for you.

stevenwdv commented 5 years ago

Just tried it but the installation failed because of missing prerequisites... Did you forget to update some version numbers?

VSIXInstaller_1a1342b6-3b6a-4b4f-add4-9b55c85487c1.log

SugoiDev commented 5 years ago

Oops!

Thanks for the logs, it helped narrow it down very quickly!

I fixed the dep issue (Vs 2019 won't let me set [15.0, 17) properly. It will show as 15.0, but will actually be 16. something in the actual manifest).

But, after fixing this, I found a serious threading issue that I didn't have time to look deeper yet. I had to do some minor changes to support this AsyncPackage thing, and I don't have much experience with threading.

This new issue locks the UI thread when LocalHistory is the only extension installed (#8)

SugoiDev commented 5 years ago

I took a few shots today but could not get it working perfectly.

If anyone is interested, I can upload a version here that works, but isn't perfect. It has the following issues:

if the window is open when you first start VS, it will stall forever with "working on it..." and a spinner. The fix is to close the LocalHistory window before closing VS
When you first open the window while having a file that has some history open, it will show the correct number of revisions in title, but will show "nothing to show" in the pane. The fix is to click the file in the solution explorer.

OrbintSoft commented 4 years ago

I want try to work on it, I dunno if I am able because it's the first time that I work on a visual studio extension. But I want try, for now I created a fork and I am updating dependencies.

SugoiDev commented 4 years ago

@OrbintSoft Is your fork working properly with VS 2019? I ended up not working on it anymore, since I no longer work with Visual Studio, but it seems there is enough interest in the extension, so I'm thinking of giving it another try.

OrbintSoft commented 4 years ago

No, it's not working, it breaks visual studio. I don't know very well where is the issue, so I am implementing unit testing, but I have so few time to dedicate that I am not sure that I'll ever be able to release a stable version. I try to find up so more time, because I really want make it stable.

megholm commented 2 years ago

Any news on 2019 support? I really like the concept of this Local History!

SugoiDev commented 2 years ago

I haven't worked with VS for many years now. @OrbintSoft has a more up to date fork, but I'm unsure of the current status with VS2019.

stevenwdv commented 2 years ago

@megholm You can give VSHistory a try instead

megholm commented 2 years ago

@stevenwdv, thanks. I did try to find alternatives in the market, but apparently failed. Thanks for the pointer 🤘🏻