LostArtefacts / TR2X

Decompilation project for Tomb Raider II (1997), along with additional enhancements and bugfixes
https://lostartefacts.dev/
GNU General Public License v3.0
58 stars 3 forks source link

Fix Bartoli sunset timer #44

Open Richard-L opened 8 months ago

Richard-L commented 8 months ago

In addition to the sky texture changing in Bartoli https://github.com/LostArtefacts/TR2X/issues/43, the overall brightness of the level changes. Apparently this happens even on OG PC TR2 too, as shown in this clip by Troye: https://cdn.discordapp.com/attachments/394838132643725314/709033420965150740/Tomb_Raider_II_2020-05-10_08-15-21_Trim.mp4

Arsunt had found that this happens over a period of 20mins. However, Core apparently messed up the timer:

Core made this feature. But they did not sync it with level timer They made separate frame counter, which was reset every time when you load game So if you load game, you need to wait another 20 minutes It's so stupid I just check the timer in statistics menu It always ticks from level start. Not level load

He then fixed the feature in TR2Main:

By the way, I made sky darker with sunset for Bartoli's Hideout. Here is how it looks now. Here is the day (start of the level). And here is the sunset. 20 minutes passed. In the original game sky keeps brightness unchanged.

aredfan commented 8 months ago

I was considering adding a request for this yesterday, regardless, thank you for doing so in a detailed way 👍

Just to add this extra piece of information:

For that I plan to add metadata in the end of savefile. A slightly larger savefile will still be compatible with the original game, but the TR2Main will be able to read additional data, such as a music track position (started by a trigger before game is saved), or a sunset state.

Source