search

LostArtefacts / TRX

Open source re-implementation of Tomb Raider I and Tomb Raider II, along with additional enhancements and bugfixes
https://lostartefacts.dev/
GNU General Public License v3.0
606 stars 38 forks source link

Passport page flipping is slow #1328

Open Richard-L opened 7 months ago

Richard-L commented 7 months ago

The passport flip animation needs to finish before a new flip input can be registered. Before you could cancel a flip at any time for faster inputs. The cancelling is possible only after a certain time, about half of the flip animation perhaps, in v3.1.1 and OG. But it's a problem in v4.0.3. Sadly can't test v4.0 as the download is instantly removed as a virus for me again...

The best solution would be that inputs can be registered immediately, and any animations cancelled accordingly.

rr- commented 7 months ago

I tried to replicate this but was unsuccessful. The most recent significant change to the passport code occurred between versions 3.0 and 3.1, so I'd expect the last version with a noticeable change to be 3.0, rather than 3.1 as the version 3.1 should be similar to what we see in 4.0.3.

walkawayy commented 6 months ago

I tested as far back as 2.13.2, and I don't see any difference in behavior. You can inconsistently flip slightly faster in all versions if the input is timed. But it's not really skipping and it's not that much faster.

The difference in behavior may be related to the slight input lag added from the animation interpolation IMO.

Richard-L commented 6 months ago

That's a good thought. Sorry I didn't test back myself and thanks you did so!

I did feel if it wouldn't just be desirable to make it skipable full stop. I still stumble upon this when navigating the passport. Think it's much nicer without any forced input delay whatsoever here.

walkawayy commented 6 months ago

@Richard-L how weird is this lol. Rudimentary attempt at removing the delay as a proof of concept.

TR1X No Delay Inv v1.zip

Richard-L commented 6 months ago

@walkawayy It's fantastic, please merge, and thank you so much ❤️

Richard-L commented 3 months ago

@walkawayy just to feed back on this again as I'm missing it not being merged all the time 😇: the only issue left to address would be that on using quickload/-save, the passport open anim is skipped too which wasn't the intention with this issue - that is to only allow skipping page flipping upon manual input.

When using quick save: The passport animates in and flips one page before the save menu appears. When using quick load: The passport animates in and doesn't flip a page before the save menu appears.

In your above build, these animations are both skipped unfortunately.

For a memory aid:

https://github.com/user-attachments/assets/222ad0dd-cd25-4222-88aa-a504a8c69325